2003-01-22 15:28:22

by Daniel Ritz

[permalink] [raw]
Subject: [PATCH 2.5] OSS mpu401 exit fix

hello

who is 2.5 OSS maintainer?

if it's not removed then it should be at least stable. patch to fix module
unload bug in mu401. io and irq can't be __initdata since they're used for
the exit function as well...

rgds,
-daniel


===== sound/oss/mpu401.c 1.9 vs edited =====
--- 1.9/sound/oss/mpu401.c Mon Dec 30 04:18:41 2002
+++ edited/sound/oss/mpu401.c Wed Jan 22 16:29:39 2003
@@ -1762,13 +1762,13 @@

static struct address_info cfg;

-static int __initdata io = -1;
-static int __initdata irq = -1;
+static int io = -1;
+static int irq = -1;

MODULE_PARM(irq, "i");
MODULE_PARM(io, "i");

-int __init init_mpu401(void)
+static int __init init_mpu401(void)
{
int ret;
/* Can be loaded either for module use or to provide functions
@@ -1785,7 +1785,7 @@
return 0;
}

-void __exit cleanup_mpu401(void)
+static void __exit cleanup_mpu401(void)
{
if (io != -1 && irq != -1) {
/* Check for use by, for example, sscape driver */


2003-01-28 13:00:49

by Alan

[permalink] [raw]
Subject: Re: [PATCH 2.5] OSS mpu401 exit fix

On Wed, 2003-01-22 at 15:37, Daniel Ritz wrote:
> hello
>
> who is 2.5 OSS maintainer?

AFAIK it doesn't have one.