2003-01-24 09:15:39

by Ph. Marek

[permalink] [raw]
Subject: arch/ia64/sn/io/hcl.c debug bug

Hello Bent, hi Ingo,

I found a debug bug :-)

I took this email-adresses as they are the
only ones in MAINTAINERS listed for an SGI.
Sorry if I've told the wrong people.


Regards,

Phil



diff -u linux-2.5.59.orig/./arch/ia64/sn/io/hcl.c linux-2.5.59/./arch/ia64/sn/io/hcl.c
-- linux-2.5.59.orig/./arch/ia64/sn/io/hcl.c Fri Jan 24 10:19:44 2003
+++ linux-2.5.59/./arch/ia64/sn/io/hcl.c Fri Jan 24 10:19:46 2003
@@ -1257,7 +1257,7 @@
* It does not make any sense to call this on vertexes with multiple
* inventory structs chained together
*/
- if ( device_inventory_get_next(device, &invplace) != NULL ) {
+ if ( device_inventory_get_next(device, &invplace) != NULL )
printk("Should panic here ... !\n");
#endif
return (val);




2003-01-24 11:15:37

by Keith Owens

[permalink] [raw]
Subject: Re: arch/ia64/sn/io/hcl.c debug bug

On Fri, 24 Jan 2003 10:25:03 +0100,
"Ph. Marek" <[email protected]> wrote:
>Hello Bent, hi Ingo,
>I took this email-adresses as they are the
>only ones in MAINTAINERS listed for an SGI.
>Sorry if I've told the wrong people.

Send arch/ia64/sn bugs to [email protected], until we get an official SGI
maintainer assigned for the SNIA code in the kernel. Thanks for
finding this bug.

>diff -u linux-2.5.59.orig/./arch/ia64/sn/io/hcl.c linux-2.5.59/./arch/ia64/sn/io/hcl.c
>-- linux-2.5.59.orig/./arch/ia64/sn/io/hcl.c Fri Jan 24 10:19:44 2003
>+++ linux-2.5.59/./arch/ia64/sn/io/hcl.c Fri Jan 24 10:19:46 2003
>@@ -1257,7 +1257,7 @@
> * It does not make any sense to call this on vertexes with multiple
> * inventory structs chained together
> */
>- if ( device_inventory_get_next(device, &invplace) != NULL ) {
>+ if ( device_inventory_get_next(device, &invplace) != NULL )
> printk("Should panic here ... !\n");
> #endif
> return (val);

2003-01-24 11:25:03

by Ph. Marek

[permalink] [raw]
Subject: Re: arch/ia64/sn/io/hcl.c debug bug

> >I took this email-adresses as they are the
> >only ones in MAINTAINERS listed for an SGI.
> >Sorry if I've told the wrong people.
>
> Send arch/ia64/sn bugs to [email protected], until we get an official SGI
> maintainer assigned for the SNIA code in the kernel. Thanks for
> finding this bug.
Sorry, I will for future bugs found.
But as of now I've abandoned the arch/ia64 as it's too complicated for my
script.


Thank you!


Regards,

Phil