2003-01-27 18:05:35

by Dieter Nützel

[permalink] [raw]
Subject: Re: [PATCH] data logging patches available for 2.4.21-preX

Chris Mason wrote:
> Hello all,
>
> I've updated the data logging patches to 2.4.21-pre3, once the suse
> mirror is done updating, you can download them from:
>
> ftp.suse.com/pub/people/mason/patches/data-logging/2.4.21
>
> Changes:
>
> mount -o remount can switch between data modes.
>
> transaction overflow bug fix (BUG in journal_mark_dirty)
>
> fix for -ENOSPC hang when the block size < page size (ia64, alpha)
>
> integration with akpm's b_journal_head code from -ac. Should make it
> possible for these patches to work both on vanilla kernels and Alan's
> branch. I haven't tried this yet though, so testers would be
> appreciated.
>
> commit_super is now sync_fs
>
> I had to rework some of the data=ordered buffer handling code to merge
> with the changes in 2.4.21-preX, so use some caution with this code.

Hello Chris,

as always very nice work!
I have it now running fine on top of 2.4.21-pre3-jam3 (2.4.21-pre3aa1).
Some fiddling was necessary but went smooth after all.
My /home partition is mounted with -o data=ordered and the performance is
great. Sorry, no real benchmarks, yet.

But some question stay open:
Where is 01-akpm-sync_fs-fix-2.diff and 01-iput-deadlock-fix.diff?
Isn't it needed anylonger 'cause you merged them and SuSE's ftp isn't updated
yet? All files are the "old" one's from 15. January.
ftp://ftp.suse.com/pub/people/mason/patches/data-logging/2.4.21

What about patch-2.4.20.rfs.06.05-transaction-overflow-fix-0.diff?
Should I put it on top, too?

Thanks,
Dieter

--
Dieter N?tzel
Graduate Student, Computer Science

University of Hamburg
Department of Computer Science
@home: Dieter.Nuetzel at hamburg.de (replace at with @)


2003-01-27 18:24:06

by Chris Mason

[permalink] [raw]
Subject: Re: [PATCH] data logging patches available for 2.4.21-preX

On Mon, 2003-01-27 at 13:14, Dieter N?tzel wrote:

> Hello Chris,
>
> as always very nice work!
> I have it now running fine on top of 2.4.21-pre3-jam3 (2.4.21-pre3aa1).
> Some fiddling was necessary but went smooth after all.
> My /home partition is mounted with -o data=ordered and the performance is
> great. Sorry, no real benchmarks, yet.
>

Thanks for trying them out.

> But some question stay open:
> Where is 01-akpm-sync_fs-fix-2.diff

01-akpm-sync_fs-fix-2.diff is in the 2.4.21 data logging directory you
linked to below.

> and 01-iput-deadlock-fix.diff?

This is in the namesys pending directory, but doesn't apply cleanly
yet. I'm rediffing both the quota code and the data logging code on top
of 01-iput-deadlock-fix (or I might just steal Manuel's rediff, which is
still in my linuxworld backlog).

> Isn't it needed anylonger 'cause you merged them and SuSE's ftp isn't updated
> yet? All files are the "old" one's from 15. January.
> ftp://ftp.suse.com/pub/people/mason/patches/data-logging/2.4.21
>
> What about patch-2.4.20.rfs.06.05-transaction-overflow-fix-0.diff?
> Should I put it on top, too?

That is included in 05-data-logging-33.

-chris

2003-01-27 18:41:05

by Dieter Nützel

[permalink] [raw]
Subject: Re: [PATCH] data logging patches available for 2.4.21-preX

Am Montag, 27. Januar 2003 19:33 schrieb Chris Mason:
> On Mon, 2003-01-27 at 13:14, Dieter N?tzel wrote:
> > Hello Chris,
> >
> > as always very nice work!
> > I have it now running fine on top of 2.4.21-pre3-jam3 (2.4.21-pre3aa1).
> > Some fiddling was necessary but went smooth after all.
> > My /home partition is mounted with -o data=ordered and the performance is
> > great. Sorry, no real benchmarks, yet.
>
> Thanks for trying them out.
>
> > But some question stay open:
> > Where is 01-akpm-sync_fs-fix-2.diff
>
> 01-akpm-sync_fs-fix-2.diff is in the 2.4.21 data logging directory you
> linked to below.

It was and I have it but it isn't any longer...
Both 01- are missing, now

> > and 01-iput-deadlock-fix.diff?
>
> This is in the namesys pending directory, but doesn't apply cleanly
> yet.

OK, you moved it;-)

> I'm rediffing both the quota code and the data logging code on top
> of 01-iput-deadlock-fix (or I might just steal Manuel's rediff, which is
> still in my linuxworld backlog).

Manuel's version (33b) had some trouble with -pre3aa1 (-pre3-jam3), too.

> > Isn't it needed anylonger 'cause you merged them and SuSE's ftp isn't
> > updated yet? All files are the "old" one's from 15. January.
> > ftp://ftp.suse.com/pub/people/mason/patches/data-logging/2.4.21
> >
> > What about patch-2.4.20.rfs.06.05-transaction-overflow-fix-0.diff?
> > Should I put it on top, too?
>
> That is included in 05-data-logging-33.

Nice, no recompile needed then ;-)

I'll do some "normal" vs data=journal/ordered "time synctest -F -f -n 1 -t 100
dir_name" tests, now.

Maybe I integrate preemption...

-Dieter