2003-02-28 09:03:06

by Duncan Sands

Subject: [PATCH] USB speedtouch: don't race the tasklets

speedtouch.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
--- a/drivers/usb/misc/speedtouch.c Fri Feb 28 10:08:32 2003
+++ b/drivers/usb/misc/speedtouch.c Fri Feb 28 10:08:32 2003
@@ -326,10 +326,10 @@

dbg ("udsl_complete_receive entered (urb 0x%p, status %d)", urb, urb->status);

- tasklet_schedule (&instance->receive_tasklet);
/* may not be in_interrupt() */
spin_lock_irqsave (&instance->completed_receivers_lock, flags);
list_add_tail (&rcv->list, &instance->completed_receivers);
+ tasklet_schedule (&instance->receive_tasklet);
spin_unlock_irqrestore (&instance->completed_receivers_lock, flags);
}

@@ -489,11 +489,11 @@

dbg ("udsl_complete_send entered (urb 0x%p, status %d)", urb, urb->status);

- tasklet_schedule (&instance->send_tasklet);
/* may not be in_interrupt() */
spin_lock_irqsave (&instance->send_lock, flags);
list_add (&snd->list, &instance->spare_senders);
list_add (&snd->buffer->list, &instance->spare_buffers);
+ tasklet_schedule (&instance->send_tasklet);
spin_unlock_irqrestore (&instance->send_lock, flags);
}

2003-02-28 20:44:50

by Pete Zaitcev

Subject: Re: [PATCH] USB speedtouch: don't race the tasklets

> speedtouch.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

My news gateway ate all interesting headers, so I cannot tell
if you cc-ed it properly. The common practice is to send
patches to: [email protected] and cc: [email protected].
Linus probably won't pick anything USB directly off l-k.

-- Pete

2003-02-28 21:30:49

by Greg KH

Subject: Re: [PATCH] USB speedtouch: don't race the tasklets

On Fri, Feb 28, 2003 at 10:12:52AM +0100, Duncan Sands wrote:
> speedtouch.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

greg k-h

2003-03-01 20:04:40

by Duncan Sands

Subject: Re: [PATCH] USB speedtouch: don't race the tasklets

On Friday 28 February 2003 21:55, Pete Zaitcev wrote:
> > speedtouch.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
>
> My news gateway ate all interesting headers, so I cannot tell
> if you cc-ed it properly. The common practice is to send
> patches to: [email protected] and cc: [email protected].
> Linus probably won't pick anything USB directly off l-k.

Hi Pete - that's what I did. I cc-ed the lkml in the hope of having the
patches flamed (= learning for me) by some of the fire-breathers there.

All the best,

Duncan.