2003-03-06 10:04:20

by Geoffrey Lee

[permalink] [raw]
Subject: [PATCH] fix undefined reference for sis drm.

Hi all,


This fixes a bug where where if sis fb is not set and sis drm is
selected then there will be undefined references to sis_malloc() and
sis_free().

What I've done is a sort of a bandaid because I don't have hardware
to fix and test.


-- G.
--
char p[] = "\xeb\x1f\x5e\x89\x76\x08\x31\xc0\x88\x46\x07\x89\x46\x0c\xb0\x0b"
"\x89\xf3\x8d\x4e\x08\x8d\x56\x0c\xcd\x80\x31\xdb\x89\xd8\x40\xcd"
"\x80\xe8\xdc\xff\xff\xff/bin/sh";



Attachments:
(No filename) (442.00 B)
Config.in.patch (529.00 B)
Configure.help.patch (536.00 B)
Download all attachments

2003-03-06 14:03:00

by Alan

[permalink] [raw]
Subject: Re: [PATCH] fix undefined reference for sis drm.

On Thu, 2003-03-06 at 10:10, Geoffrey Lee wrote:
> Hi all,
>
>
> This fixes a bug where where if sis fb is not set and sis drm is
> selected then there will be undefined references to sis_malloc() and
> sis_free().
>
> What I've done is a sort of a bandaid because I don't have hardware
> to fix and test.

Direct render occurs before the frame buffer so it doesn't work
In addition you can have both modular so you'd want to make it

dep_tristate ' SiS' CONFIG_DRM_SIS $CONFIG_AGP $CONFIG_FB_SIS

even if the order worked out.

2003-03-06 15:06:49

by Geoffrey Lee

[permalink] [raw]
Subject: Re: [PATCH] fix undefined reference for sis drm.

>
> Direct render occurs before the frame buffer so it doesn't work
> In addition you can have both modular so you'd want to make it
>
> dep_tristate ' SiS' CONFIG_DRM_SIS $CONFIG_AGP $CONFIG_FB_SIS
>
> even if the order worked out.


Hm, yes indeed. Please apply the correct fix to your tree.

Sorry about the botched fix.


-- G.

--
char p[] = "\xeb\x1f\x5e\x89\x76\x08\x31\xc0\x88\x46\x07\x89\x46\x0c\xb0\x0b"
"\x89\xf3\x8d\x4e\x08\x8d\x56\x0c\xcd\x80\x31\xdb\x89\xd8\x40\xcd"
"\x80\xe8\xdc\xff\xff\xff/bin/sh";