2003-03-09 20:31:38

by Oleg Drokin

[permalink] [raw]
Subject: Memleak in Windows Logical Disk Manager partition handler

Hello!

Not freeing allocated memory on error exit path.
See the patch.
Should apply to both 2.4 and 2.5.
Found with help of smatch + enhanced unfree script.

Bye,
Oleg

===== fs/partitions/ldm.c 1.6 vs edited =====
--- 1.6/fs/partitions/ldm.c Mon Aug 12 00:08:42 2002
+++ edited/fs/partitions/ldm.c Sun Mar 9 23:38:15 2003
@@ -1223,8 +1223,10 @@
return FALSE;
}

- if (!ldm_parse_vblk (data, len, vb))
+ if (!ldm_parse_vblk (data, len, vb)) {
+ kfree(vb);
return FALSE; /* Already logged */
+ }

/* Put vblk into the correct list. */
switch (vb->type) {