Hello!
There is a memleak on error exit path, identical in 2.4 and 2.5.
Same patch should apply to 2.4 and 2.5.
Found with help of smatch + enhanced unfree script.
Bye,
Oleg
===== net/8021q/vlanproc.c 1.6 vs edited =====
--- 1.6/net/8021q/vlanproc.c Sat Aug 10 06:36:57 2002
+++ edited/net/8021q/vlanproc.c Mon Mar 10 00:17:23 2003
@@ -252,8 +252,10 @@
offs = file->f_pos;
if (offs < pos) {
len = min_t(int, pos - offs, count);
- if (copy_to_user(buf, (page + offs), len))
+ if (copy_to_user(buf, (page + offs), len)) {
+ kfree(page);
return -EFAULT;
+ }
file->f_pos += len;
} else {