2003-03-12 18:59:04

by Oleg Drokin

[permalink] [raw]
Subject: [2.4] Memleak in Essential RoadRunner HIPPI board driver

Hello!

There is memleak on error exit path. Seems there was some confusion
in the mind of whoever added that zeroing statement.
The patch is trivial, 2.5 is not affected.
Found with help of smatch + enhanced unfree script

Bye,
Oleg

===== drivers/net/rrunner.c 1.6 vs edited =====
--- 1.6/drivers/net/rrunner.c Thu Feb 28 16:57:24 2002
+++ edited/drivers/net/rrunner.c Wed Mar 12 22:05:15 2003
@@ -1216,7 +1216,6 @@

rrpriv->info = kmalloc(sizeof(struct rr_info), GFP_KERNEL);
if (!rrpriv->info){
- rrpriv->rx_ctrl = NULL;
ecode = -ENOMEM;
goto error;
}