2003-03-13 19:58:05

by Eduardo Pereira Habkost

[permalink] [raw]
Subject: [PATCH] Allow to compile IDE as module

Marcelo, the following patch fixes drivers/ide/Makefile
to allow to use CONFIG_BLK_DEV_IDE=m.

--
Eduardo


# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1014 -> 1.1015
# drivers/ide/Makefile 1.10 -> 1.11
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/03/13 [email protected] 1.1015
# Makefile:
# Fix ide Makefile to allow CONFIG_BLK_DEV_IDE as module
# --------------------------------------------
#
diff -Nru a/drivers/ide/Makefile b/drivers/ide/Makefile
--- a/drivers/ide/Makefile Thu Mar 13 17:01:12 2003
+++ b/drivers/ide/Makefile Thu Mar 13 17:01:12 2003
@@ -35,9 +35,13 @@
obj-$(CONFIG_BLK_DEV_IDETAPE) += ide-tape.o
obj-$(CONFIG_BLK_DEV_IDEFLOPPY) += ide-floppy.o

-obj-$(CONFIG_BLK_DEV_IDEPCI) += setup-pci.o
-obj-$(CONFIG_BLK_DEV_IDEDMA_PCI) += ide-dma.o
-obj-$(CONFIG_BLK_DEV_ISAPNP) += ide-pnp.o
+# These options are boolean, but the files must be
+# on obj-m if CONFIG_BLK_DEV is m:
+ide-obj-$(CONFIG_BLK_DEV_IDEPCI) += setup-pci.o
+ide-obj-$(CONFIG_BLK_DEV_IDEDMA_PCI) += ide-dma.o
+ide-obj-$(CONFIG_BLK_DEV_ISAPNP) += ide-pnp.o
+
+obj-$(CONFIG_BLK_DEV) += ide-obj-y


ifeq ($(CONFIG_BLK_DEV_IDE),y)


Attachments:
(No filename) (1.37 kB)
(No filename) (189.00 B)
Download all attachments

2003-03-13 21:52:25

by Eduardo Pereira Habkost

[permalink] [raw]
Subject: Re: [PATCH] Allow to compile IDE as module


Oops. Don't apply it.
I've not tested it before, and noticed that it is not so
simple. There are other parts that are being included on
vmlinux that need symbols from the ide module.

On Thu, Mar 13, 2003 at 05:08:04PM -0300, Eduardo Pereira Habkost wrote:
> Marcelo, the following patch fixes drivers/ide/Makefile
> to allow to use CONFIG_BLK_DEV_IDE=m.
>
> --
> Eduardo
>
<snip>
> +
> +obj-$(CONFIG_BLK_DEV) += ide-obj-y

Ouch, it would not work, anyway.
I promise that I will test the changes, next time. :-)

--
Eduardo


Attachments:
(No filename) (532.00 B)
(No filename) (189.00 B)
Download all attachments