2003-03-19 11:44:53

by Mathiasen, Torben

[permalink] [raw]
Subject: [PATCH] cpqphp 66/100/133MHz PCI-X support for 2.5.65

Hi Greg,

After being put on hold for a while (needed fixes to CCISS driver, etc) I
attached a patch that adds pci-x support to the cpqphp driver in 2.5.65.

Changes:
Adds 66/100/133MHz PCI-X support.
Adds support for dynamically chaning frequency and mode.
Changes code to also blink the power LED when powering down.
Uses the IRQ from PCI config space if the ROM resource table doesn't
provide one (would previously use the same interrupt as the hotplug
controller which would lead to bad things when trying to update routing
tables). Dan Zink should have the credit for this fix.
Changes find_slot() to cpqhp_find_slot().
Uses sysfs to display speed/freq.
Some documentation updates.

It seems you're in the middle of updating all hotplug drivers. The cpqphp
driver will oops if you plug in any adapter (unrelated to this patch). I'm sure
you're aware of this so I didn't bother looking into a fix. It happens because
pci_scan_slot() now returns an integer instead of a struct pci_dev*.

A 2.4 version is also done and working as expected (tested with CCISS, nics, etc).
When would you prefer to have that patch?

Thanks,
Torben


Attachments:
(No filename) (1.12 kB)
linux-2.5.65-pcix-1.diff (19.31 kB)
Download all attachments

2003-03-19 21:31:18

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] cpqphp 66/100/133MHz PCI-X support for 2.5.65

On Wed, Mar 19, 2003 at 12:57:04PM +0100, Torben Mathiasen wrote:
> Hi Greg,
>
> After being put on hold for a while (needed fixes to CCISS driver, etc) I
> attached a patch that adds pci-x support to the cpqphp driver in 2.5.65.

Thanks a lot for the patch. I've added it to my trees and will send it
on to Linus in a few days.

> It seems you're in the middle of updating all hotplug drivers. The cpqphp
> driver will oops if you plug in any adapter (unrelated to this patch). I'm sure
> you're aware of this so I didn't bother looking into a fix. It happens because
> pci_scan_slot() now returns an integer instead of a struct pci_dev*.

Yeah, I'm working on fixing that up right now :(

> A 2.4 version is also done and working as expected (tested with CCISS, nics, etc).
> When would you prefer to have that patch?

I'd be glad to take it now if you have it.

thanks again for the patch,

greg k-h

2003-03-20 11:20:24

by Mathiasen, Torben

[permalink] [raw]
Subject: Re: [PATCH] cpqphp 66/100/133MHz PCI-X support for 2.5.65

On Wed, Mar 19 2003, Greg KH wrote:
> I'd be glad to take it now if you have it.
>

Cool. Its attached. Patch against 2.4.21pre5 but also applies to current BK.

Thanks,
Torben


Attachments:
(No filename) (177.00 B)
linux-2.4.21pre5-pcix-1.diff (18.25 kB)
Download all attachments