2003-03-21 19:41:41

by Petr Vandrovec

Subject: [PATCH] Fix kobject_get oopses triggered by i2c in 2.5.65-bk

Hi,

i2c initialization must not use module_init now, when it was converted
to the kobject interface. There are dozens of users which need it working
much sooner. i2c is subsystem after all, isn't it?

Fixes kernel oopses in kobject_get during system init which were happening
to me.

Petr Vandrovec
[email protected]

--- vger/drivers/i2c/i2c-core.c 2003-03-21 19:06:32.000000000 +0100
+++ linux/drivers/i2c/i2c-core.c 2003-03-21 20:42:13.000000000 +0100
@@ -675,7 +675,7 @@
bus_unregister(&i2c_bus_type);
}

-module_init(i2c_init);
+subsys_initcall(i2c_init);
module_exit(i2c_exit);

/* ----------------------------------------------------

2003-03-21 20:14:05

by Greg KH

Subject: Re: [PATCH] Fix kobject_get oopses triggered by i2c in 2.5.65-bk

On Fri, Mar 21, 2003 at 08:51:14PM +0100, Petr Vandrovec wrote:
> Hi,
>
> i2c initialization must not use module_init now, when it was converted
> to the kobject interface. There are dozens of users which need it working
> much sooner. i2c is subsystem after all, isn't it?
>
> Fixes kernel oopses in kobject_get during system init which were happening
> to me.

Thanks, I've added this to my tree, and will send it on to Linus in the
next round of i2c changes.

thanks,

greg k-h