-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Content-Type: text/plain; charset=us-ascii
ftp://ftp.<country>.kernel.org/pub/linux/utils/kernel/modutils/v2.4
modutils-2.4.24.tar.gz Source tarball, includes RPM spec file
modutils-2.4.24-1.src.rpm As above, in SRPM format
modutils-2.4.24-1.i386.rpm Compiled with gcc 2.96 20000731,
glibc 2.2.2.
modutils-2.4.24-1.ia64.rpm Compiled with gcc 2.96-ia64-20000731,
glibc-2.2.3.
patch-modutils-2.4.24.gz Patch from modutils 2.4.23 to 2.4.24.
Changelog extract
* Remove the default of exporting all symbols, but only on
architectures that have function descriptors (ia64, ppc64).
* Add libmodutils.a to make clean list.
This version of modutils is functionally identical to 2.4.23 except for
those architectures that have function descriptors, i.e. ia64 and
ppc64.
For historical reasons, insmod and depmod treat modules with neither
EXPORT_SYMBOL() nor EXPORT_NO_SYMBOLS() as exporting everything. This
provides backwards compatibility with 2.0 kernels and some 2.2 modules.
No new code should be relying on this behaviour and the feature has
been removed in 2.5 kernels. Unfortunately some developers are still
relying on this default behaviour, even for new code.
When an architecture has function descriptors and uses EXPORT_SYMBOL()
on a function, gcc generates a function descriptor and ksymtab contains
the address of that descriptor. Without an explicit EXPORT_SYMBOL(),
gcc does not generate a function descriptor and the exported symbol
points to the start of the function body. Any attempt to call to that
function tries to use the start of the function code as a descriptor
and breaks spectacularly.
To prevent this kernel breakage, I am making an incompatible change to
modutils. It only affects ia64 and ppc64 users, and only if they are
relying on the deprecated feature of all symbols being exported.
Users on ia64 and ppc64 must ensure that their modules still resolve
and add EXPORT_SYMBOL() where necessary before doing a permanent
upgrade to modutils 2.4.24. The simplest way to check is to build (but
not install) modutils-2.4.24 then ./depmod/depmod -nae > /dev/null.
Any unresolved references that did not occur with modutils 2.4.23 need
an explicit EXPORT_SYMBOL(). If this is too much bother, stay on
modutils 2.4.23 and risk the kernel breakage.
Other architectures can safely upgrade to 2.4.24 with no change, or
they can stay on 2.4.23.
If anybody fancies a janatorial task, configure modutils 2.4.24 with
CFLAGS="-O2 -Wall -DHAS_FUNCTION_DESCRIPTORS" ./configure, build it
then run ./depmod/depmod -nae > /dev/null. You can do that on any
architecture to find kernel modules that still rely on exporting all
symbols.
No, I am not going to fudge modutils 2.4 to allow the continued default
export of data symbols but not text symbols on ia64 and ppc64. It is
too much extra work just to allow the continued use of a deprecated
feature that has already been removed in 2.5 kernels.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Exmh version 2.1.1 10/15/1999
iD8DBQE+fSbti4UHNye0ZOoRAl2/AJ9Oi6nPAcimNXk61bMS0awByxFt/ACgzkxz
Rk0dK41PNPEKlShX/9Utd6w=
=tdBH
-----END PGP SIGNATURE-----
On Sun, Mar 23, 2003 at 02:16:01PM +1100, Keith Owens wrote:
> This version of modutils is functionally identical to 2.4.23 except for
> those architectures that have function descriptors, i.e. ia64 and
> ppc64.
parisc also has function descriptors. what needs to happen for us?
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
On Sun, 23 Mar 2003 03:23:18 +0000,
Matthew Wilcox <[email protected]> wrote:
>On Sun, Mar 23, 2003 at 02:16:01PM +1100, Keith Owens wrote:
>> This version of modutils is functionally identical to 2.4.23 except for
>> those architectures that have function descriptors, i.e. ia64 and
>> ppc64.
>
>parisc also has function descriptors. what needs to happen for us?
Index: 24.3/include/util.h
--- 24.3/include/util.h Sun, 23 Mar 2003 13:34:28 +1100 kaos (modutils-2.4/51_util.h 1.4 644)
+++ 24.3(w)/include/util.h Sun, 23 Mar 2003 14:28:36 +1100 kaos (modutils-2.4/51_util.h 1.4 644)
@@ -96,7 +96,7 @@ void gzf_close(int fd);
#define SYMPREFIX "__insmod_";
extern const char symprefix[10]; /* Must be sizeof(SYMPREFIX), including nul */
-#if defined(ARCH_ia64) || defined(ARCH_ppc64)
+#if defined(ARCH_ia64) || defined(ARCH_ppc64) || defined(ARCH_hppa64)
#define HAS_FUNCTION_DESCRIPTORS
#endif
> -#if defined(ARCH_ia64) || defined(ARCH_ppc64)
> +#if defined(ARCH_ia64) || defined(ARCH_ppc64) || defined(ARCH_hppa64)
> #define HAS_FUNCTION_DESCRIPTORS
> #endif
The 32-bit hppa port also has function descriptors.
Dave
--
J. David Anglin [email protected]
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
On Sat, 22 Mar 2003 22:37:43 -0500 (EST),
"John David Anglin" <[email protected]> wrote:
>> -#if defined(ARCH_ia64) || defined(ARCH_ppc64)
>> +#if defined(ARCH_ia64) || defined(ARCH_ppc64) || defined(ARCH_hppa64)
>> #define HAS_FUNCTION_DESCRIPTORS
>> #endif
>
>The 32-bit hppa port also has function descriptors.
They keep coming out of the woodwork :( Any more architectures using
function descriptors? Just add them to the list below.
Index: 24.3/include/util.h
--- 24.3/include/util.h Sun, 23 Mar 2003 13:34:28 +1100 kaos (modutils-2.4/51_util.h 1.4 644)
+++ 24.3(w)/include/util.h Sun, 23 Mar 2003 14:40:06 +1100 kaos (modutils-2.4/51_util.h 1.4 644)
@@ -96,7 +96,7 @@ void gzf_close(int fd);
#define SYMPREFIX "__insmod_";
extern const char symprefix[10]; /* Must be sizeof(SYMPREFIX), including nul */
-#if defined(ARCH_ia64) || defined(ARCH_ppc64)
+#if defined(ARCH_ia64) || defined(ARCH_ppc64) || defined(ARCH_hppa) || defined(ARCH_hppa64)
#define HAS_FUNCTION_DESCRIPTORS
#endif