2003-03-24 15:41:50

by Duncan Sands

[permalink] [raw]
Subject: drivers/serial/Makefile

The serial driver is now compiled as "8250", rather than
the traditional "serial" (Kconfig says "serial" as well).
Assuming this was a mistake in the Makefile, I went and
had a look, but my brain exploded. What exactly is this
intended to do?

All the best,

"Confused"

PS: 8250_gsc, 8250_pci can be compiled as modules in their
own right.

#
# Makefile for the kernel serial device drivers.
#
# $Id: Makefile,v 1.8 2002/07/21 21:32:30 rmk Exp $
#

serial-8250-y :=
serial-8250-$(CONFIG_GSC) += 8250_gsc.o
serial-8250-$(CONFIG_PCI) += 8250_pci.o
serial-8250-$(CONFIG_PNP) += 8250_pnp.o
obj-$(CONFIG_SERIAL_CORE) += core.o
obj-$(CONFIG_SERIAL_21285) += 21285.o
obj-$(CONFIG_SERIAL_8250) += 8250.o $(serial-8250-y)
obj-$(CONFIG_SERIAL_8250_CS) += 8250_cs.o
obj-$(CONFIG_SERIAL_8250_ACORN) += 8250_acorn.o
obj-$(CONFIG_SERIAL_ANAKIN) += anakin.o
obj-$(CONFIG_SERIAL_AMBA) += amba.o
obj-$(CONFIG_SERIAL_CLPS711X) += clps711x.o
obj-$(CONFIG_SERIAL_SA1100) += sa1100.o
obj-$(CONFIG_SERIAL_UART00) += uart00.o
obj-$(CONFIG_SERIAL_SUNCORE) += suncore.o
obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o
obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o
obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o
obj-$(CONFIG_SERIAL_MUX) += mux.o
obj-$(CONFIG_SERIAL_68328) += 68328serial.o
obj-$(CONFIG_SERIAL_68360) += 68360serial.o
obj-$(CONFIG_SERIAL_COLDFIRE) += mcfserial.o
obj-$(CONFIG_V850E_NB85E_UART) += nb85e_uart.o


2003-03-24 16:04:47

by Russell King

[permalink] [raw]
Subject: Re: drivers/serial/Makefile

On Mon, Mar 24, 2003 at 04:52:50PM +0100, Duncan Sands wrote:
> The serial driver is now compiled as "8250", rather than
> the traditional "serial" (Kconfig says "serial" as well).
> Assuming this was a mistake in the Makefile, I went and
> had a look, but my brain exploded.

It isn't a mistake. "serial" is meaningless with you've got multiple
serial ports of different types. It's a general name of a class of
devices, not a specific device.

> What exactly is this intended to do?

Well, core.c is the core driver which knows how to talk to user space,
and on to that bolts the hardware specific bits, 8250.c, sa1100.c,
suncore.c etc.

> PS: 8250_gsc, 8250_pci can be compiled as modules in their
> own right.

In theory they can, and maybe one day we'll teach the Kconfig system
to allow it. Feel free to send a patch for this. 8)

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html