2003-03-27 16:58:48

by Alan

[permalink] [raw]
Subject: PATCH: DRIVERNAME SUPPRESSED DUE TO KERNEL.ORG FILTER BUGS


One from Jens - fix up the problems with older Samsung disks that don't
abort unknown commands sometimes

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.66-bk3/drivers/ide/ide-disk.c linux-2.5.66-ac1/drivers/ide/ide-disk.c
--- linux-2.5.66-bk3/drivers/ide/ide-disk.c 2003-03-27 17:13:19.000000000 +0000
+++ linux-2.5.66-ac1/drivers/ide/ide-disk.c 2003-03-26 20:23:01.000000000 +0000
@@ -1098,6 +1098,7 @@
* in above order (i.e., if value of higher priority is available,
* reset will be ignored).
*/
+#define IDE_STROKE_LIMIT (32000*1024*2)
static void init_idedisk_capacity (ide_drive_t *drive)
{
struct hd_driveid *id = drive->id;
@@ -1118,7 +1119,7 @@
drive->cyl = (unsigned int) capacity_2 / (drive->head * drive->sect);
drive->select.b.lba = 1;
set_max_ext = idedisk_read_native_max_address_ext(drive);
- if (set_max_ext > capacity_2) {
+ if (set_max_ext > capacity_2 && capacity_2 > IDE_STROKE_LIMIT) {
#ifdef CONFIG_IDEDISK_STROKE
set_max_ext = idedisk_read_native_max_address_ext(drive);
set_max_ext = idedisk_set_max_address_ext(drive, set_max_ext);
@@ -1145,7 +1146,7 @@
drive->select.b.lba = 1;
}

- if (set_max > capacity) {
+ if (set_max > capacity && capacity > IDE_STROKE_LIMIT) {
#ifdef CONFIG_IDEDISK_STROKE
set_max = idedisk_read_native_max_address(drive);
set_max = idedisk_set_max_address(drive, set_max);


2003-03-27 18:06:18

by Matti Aarnio

[permalink] [raw]
Subject: Re: PATCH: DRIVERNAME SUPPRESSED DUE TO KERNEL.ORG FILTER BUGS

It is Alan's privilege to choose whatever he wants for the email
subject, but the sad part is, that every time a reference is
made to AIC7XXX in email subject, vger's keepers get tons of
spam-rejections.

Tons of sites have bad lookups matching only "XXX" substring, and not
checking if that happens to be a substring in some word...

I have no doubt that some sites will reject even this letter
due to what I quoted in previous paragraph.

/Matti Aarnio

2003-03-27 18:52:33

by Alan

[permalink] [raw]
Subject: Re: PATCH: DRIVERNAME SUPPRESSED DUE TO KERNEL.ORG FILTER BUGS

On Thu, 2003-03-27 at 18:17, Matti Aarnio wrote:
> It is Alan's privilege to choose whatever he wants for the email
> subject, but the sad part is, that every time a reference is
> made to AIC7XXX in email subject, vger's keepers get tons of
> spam-rejections.

Let me absolutely clear I did it to fix the bounces from my
script not because I think the list admin sucks.

If the XXX substring is such a problem its time to increase
the pain factor. I think XXX will begin appearing in the body
of all my changelogs 8)

XXX subject bouncers to kernel.org should get kicked off but I
appreciate you have rather more useful things to be doing 8)


2003-03-27 20:04:56

by Gerhard Mack

[permalink] [raw]
Subject: Re: PATCH: DRIVERNAME SUPPRESSED DUE TO KERNEL.ORG FILTER BUGS

Why not simply drop the lot of em off the list?

On 27 Mar 2003, Alan Cox wrote:

> Date: 27 Mar 2003 19:04:41 +0000
> From: Alan Cox <[email protected]>
> To: Matti Aarnio <[email protected]>
> Cc: Linux Kernel Mailing List <[email protected]>,
> Linus Torvalds <[email protected]>
> Subject: Re: PATCH: DRIVERNAME SUPPRESSED DUE TO KERNEL.ORG FILTER BUGS
>
> On Thu, 2003-03-27 at 18:17, Matti Aarnio wrote:
> > It is Alan's privilege to choose whatever he wants for the email
> > subject, but the sad part is, that every time a reference is
> > made to AIC7XXX in email subject, vger's keepers get tons of
> > spam-rejections.
>
> Let me absolutely clear I did it to fix the bounces from my
> script not because I think the list admin sucks.
>
> If the XXX substring is such a problem its time to increase
> the pain factor. I think XXX will begin appearing in the body
> of all my changelogs 8)
>
> XXX subject bouncers to kernel.org should get kicked off but I
> appreciate you have rather more useful things to be doing 8)
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
Gerhard Mack

[email protected]

<>< As a computer I find your faith in technology amusing.