2003-03-30 16:30:02

by Nicholas Wourms

Subject: Re: Update direct-rendering to current DRI CVS tree.

Dave Jones wrote:
> > #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,4,2)
> > #define down_write down
> > #define up_write up
>
> #if can go, like it did in other parts of the patch.

What will replace it? If you intend to keep the two
projects in sync and easy to update, I'm afraid that it will
call for putting all the later (>=2.4.16) #if's back, as
well as adding gaurds for the current 2.5-specific
scheduling/worqueue changes. Unless, of course, the dri
maintainers are willing to make TRUNK incompatible with
linux-2.4...

Cheers,
Nicholas

2003-03-30 16:43:53

by Christoph Hellwig

Subject: Re: Update direct-rendering to current DRI CVS tree.

On Sun, Mar 30, 2003 at 09:14:58AM -0500, Nicholas Wourms wrote:
> Dave Jones wrote:
> > > #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,4,2)
> > > #define down_write down
> > > #define up_write up
> >
> > #if can go, like it did in other parts of the patch.
>
> What will replace it?

Nothing. 2.4.0/2.4.1/2.4.2 are too buggy to be used.