2003-05-05 03:37:06

by Randy.Dunlap

Subject: [PATCH] 2.5.69 drm/radeon_cp.c

Hi,

This patch to 2.5.69 fixes this warning (gcc 3.2):
drivers/char/drm/radeon_cp.c: In function `radeon_cp_init_ring_buffer':
drivers/char/drm/radeon_cp.c:908: warning: unsigned int format, different type arg (arg 3)
drivers/char/drm/radeon_cp.c:908: warning: unsigned int format, different type arg (arg 3)


Is this obvious enough? Want it to go thru someone?

--
~Randy



patch_name: drm_radeon_dma.patch
patch_version: 2003-05-04.20:32:09
author: Randy.Dunlap <[email protected]>
description: fix printk of dma_addr_t
product: Linux
product_versions: linux-2569
changelog: print dma_addr_t as unsigned long
maintainer: dunno: Ani Joshi ([email protected]),
James Simmons ([email protected]),
Gareth Hughes ([email protected]),
Rik Faith ([email protected])
diffstat: =
drivers/char/drm/radeon_cp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


diff -Naur ./drivers/char/drm/radeon_cp.c%VID ./drivers/char/drm/radeon_cp.c
--- ./drivers/char/drm/radeon_cp.c%VID 2003-05-04 16:53:06.000000000 -0700
+++ ./drivers/char/drm/radeon_cp.c 2003-05-04 20:30:30.000000000 -0700
@@ -903,8 +903,8 @@

RADEON_WRITE( RADEON_CP_RB_RPTR_ADDR,
entry->busaddr[page_ofs]);
- DRM_DEBUG( "ring rptr: offset=0x%08x handle=0x%08lx\n",
- entry->busaddr[page_ofs],
+ DRM_DEBUG( "ring rptr: offset=0x%08lx handle=0x%08lx\n",
+ (unsigned long) entry->busaddr[page_ofs],
entry->handle + tmp_ofs );
}

2003-05-06 20:59:11

by Michel Dänzer

Subject: Re: [PATCH] 2.5.69 drm/radeon_cp.c

On Mon, 2003-05-05 at 05:49, Randy.Dunlap wrote:
>
> This patch to 2.5.69 fixes this warning (gcc 3.2):
> drivers/char/drm/radeon_cp.c: In function `radeon_cp_init_ring_buffer':
> drivers/char/drm/radeon_cp.c:908: warning: unsigned int format, different type arg (arg 3)
> drivers/char/drm/radeon_cp.c:908: warning: unsigned int format, different type arg (arg 3)
>
>
> Is this obvious enough? Want it to go thru someone?

[...]

> maintainer: dunno: Ani Joshi ([email protected]),
> James Simmons ([email protected]),
> Gareth Hughes ([email protected]),
> Rik Faith ([email protected])

Make that [email protected] .

> diff -Naur ./drivers/char/drm/radeon_cp.c%VID ./drivers/char/drm/radeon_cp.c
> --- ./drivers/char/drm/radeon_cp.c%VID 2003-05-04 16:53:06.000000000 -0700
> +++ ./drivers/char/drm/radeon_cp.c 2003-05-04 20:30:30.000000000 -0700
> @@ -903,8 +903,8 @@
>
> RADEON_WRITE( RADEON_CP_RB_RPTR_ADDR,
> entry->busaddr[page_ofs]);
> - DRM_DEBUG( "ring rptr: offset=0x%08x handle=0x%08lx\n",
> - entry->busaddr[page_ofs],
> + DRM_DEBUG( "ring rptr: offset=0x%08lx handle=0x%08lx\n",
> + (unsigned long) entry->busaddr[page_ofs],
> entry->handle + tmp_ofs );
> }

Looks good to me, just committed it to the DRI CVS trunk. Thanks.


--
Earthling Michel D?nzer \ Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer