2003-05-06 15:10:25

by Ronald Bultje

[permalink] [raw]
Subject: [patch/2.5.69] zoran driver update

Hi Linus/all,

http://mjpeg.sourceforge.net/driver-zoran/linux-zoran-driver.patch.gz
contains a patch that updates the current zoran driver (v4l/v4l2 driver
for zr36057/zr36067-based MJPEG cards) in kernel 2.5.x to the newest
stable version that we have. Patch is against 2.5.69.

Differences between old and new driver:
* this one actually compiles
* this one uses the new i2c stack
* this one supports video4linux2
* this one supports new cards (LML33R10 and Miro DC30/DC30+ - we already
supported the LML33, Miro DC10/DC10+ and Iomega Buz)

It also adds some additional PCI IDs and I2C IDs that are used by the
driver, updates documentation and adds this driver + me to the
maintainer list.

The i2c changes have been reviewed by Greg KH and Frank Davis (april
7th/8th, 2003 - the 2.5.67 patch), the v4l part is in review by Gerd
Knorr.

Could this please be applied?

Thanks,

Ronald


2003-05-06 18:08:52

by Greg KH

[permalink] [raw]
Subject: Re: [patch/2.5.69] zoran driver update

On Tue, May 06, 2003 at 05:22:05PM +0200, Ronald Bultje wrote:
> Hi Linus/all,
>
> http://mjpeg.sourceforge.net/driver-zoran/linux-zoran-driver.patch.gz
> contains a patch that updates the current zoran driver (v4l/v4l2 driver
> for zr36057/zr36067-based MJPEG cards) in kernel 2.5.x to the newest
> stable version that we have. Patch is against 2.5.69.

Please go read Documentation/SubmittingPatches for why just sending a
link will not work :)

Gerd, want to pick up these patches?

thanks,

greg k-h

2003-05-06 18:40:43

by Alan

[permalink] [raw]
Subject: Re: [patch/2.5.69] zoran driver update

On Maw, 2003-05-06 at 19:22, Greg KH wrote:
> On Tue, May 06, 2003 at 05:22:05PM +0200, Ronald Bultje wrote:
> > Hi Linus/all,
> >
> > http://mjpeg.sourceforge.net/driver-zoran/linux-zoran-driver.patch.gz
> > contains a patch that updates the current zoran driver (v4l/v4l2 driver
> > for zr36057/zr36067-based MJPEG cards) in kernel 2.5.x to the newest
> > stable version that we have. Patch is against 2.5.69.
>
> Please go read Documentation/SubmittingPatches for why just sending a
> link will not work :)
>
> Gerd, want to pick up these patches?

Someone also needs to make sure the merge keeps all the security fixes
from the old driver.

2003-05-06 19:10:42

by Ronald Bultje

[permalink] [raw]
Subject: Re: [Mjpeg-developer] Re: [patch/2.5.69] zoran driver update

Hey Alan,

thanks for the comment.

On Tue, 2003-05-06 at 19:54, Alan Cox wrote:
> Someone also needs to make sure the merge keeps all the security fixes
> from the old driver.

I've diff'ed the 'old' driver versus the kernel driver (2.4.16, I
think), removing all formatting changes (someone ran indent over the
kernel driver. ;-)). The only obvious change was that semaphores were
added. The new driver has semaphores built-in, so that's taken care of.
Besides that, I don't think there were any real differences. If I missed
anything, please let me know. I'd like to add them to our CVS too, then.

Again, thanks!

Ronald

2003-05-06 19:45:07

by Gerd Knorr

[permalink] [raw]
Subject: Re: [patch/2.5.69] zoran driver update

> Gerd, want to pick up these patches?

I'll try ...

Gerd

--
sigfault

2003-05-06 20:43:34

by Alan

[permalink] [raw]
Subject: Re: [patch/2.5.69] zoran driver update

On Maw, 2003-05-06 at 20:21, Gerd Knorr wrote:
> > Gerd, want to pick up these patches?
>
> I'll try ...

I have hardware though not a lot of time if thats a help at all