2003-05-11 22:09:59

by Andrew Morton

[permalink] [raw]
Subject: Re: Slab corruption mm3 + davem fixes

"David S. Miller" <[email protected]> wrote:
>
> On Sun, 2003-05-11 at 09:21, Ed Tomlinson wrote:
> > I am also seeing this on 69-bk (as of Sunday morning)
> ...
> > On May 10, 2003 11:19 pm, Ed Tomlinson wrote:
> > > I looked at my logs and found the following error in it. My kernel is
> > > 69-mm3 with two davem fixes on it.
> ...
> > > May 10 22:41:06 oscar kernel: Call Trace:
> > > May 10 22:41:06 oscar kernel: [__slab_error+30/32] __slab_error+0x1e/0x20
> > > May 10 22:41:06 oscar kernel: [check_poison_obj+376/384]
> > > check_poison_obj+0x178/0x180 May 10 22:41:06 oscar kernel:
> > > [kmalloc+221/392] kmalloc+0xdd/0x188 May 10 22:41:06 oscar kernel:
> > > [alloc_skb+64/240] alloc_skb+0x40/0xf0 May 10 22:41:06 oscar kernel:
>
> Yeah, more bugs in the NAT netfilter changes. Debugging this one
> patch is becomming a full time job :-(
>
> This should fix it. Rusty, you're computing checksums and mangling
> src/dst using header pointers potentially pointing to free'd skbs.
>

Did you mean to send a one megabyte diff?


2003-05-11 22:18:56

by David Miller

[permalink] [raw]
Subject: Re: Slab corruption mm3 + davem fixes

From: Andrew Morton <[email protected]>
Date: Sun, 11 May 2003 15:15:06 -0700

Did you mean to send a one megabyte diff?

Fuck wrong patch, that one was a 2.4.x backport of IPSEC enjoy :-)

2003-05-11 22:23:54

by David Miller

[permalink] [raw]
Subject: Re: Slab corruption mm3 + davem fixes

On Sun, 2003-05-11 at 15:15, Andrew Morton wrote:
> "David S. Miller" <[email protected]> wrote:
> >
> > On Sun, 2003-05-11 at 09:21, Ed Tomlinson wrote:
> > > I am also seeing this on 69-bk (as of Sunday morning)
> > ...
> > > On May 10, 2003 11:19 pm, Ed Tomlinson wrote:
> > > > I looked at my logs and found the following error in it. My kernel is
> > > > 69-mm3 with two davem fixes on it.
> > ...
> > > > May 10 22:41:06 oscar kernel: Call Trace:
> > > > May 10 22:41:06 oscar kernel: [__slab_error+30/32] __slab_error+0x1e/0x20
> > > > May 10 22:41:06 oscar kernel: [check_poison_obj+376/384]
> > > > check_poison_obj+0x178/0x180 May 10 22:41:06 oscar kernel:
> > > > [kmalloc+221/392] kmalloc+0xdd/0x188 May 10 22:41:06 oscar kernel:
> > > > [alloc_skb+64/240] alloc_skb+0x40/0xf0 May 10 22:41:06 oscar kernel:
> >
> > Yeah, more bugs in the NAT netfilter changes. Debugging this one
> > patch is becomming a full time job :-(
> >
> > This should fix it. Rusty, you're computing checksums and mangling
> > src/dst using header pointers potentially pointing to free'd skbs.
> >
>
> Did you mean to send a one megabyte diff?

Let's try this again, here is the correct patch :-)



--
David S. Miller <[email protected]>


Attachments:
diff (4.16 kB)

2003-05-12 07:31:28

by Ed Tomlinson

[permalink] [raw]
Subject: Re: Slab corruption mm3 + davem fixes

On May 11, 2003 06:34 pm, David S. Miller wrote:
> > > Yeah, more bugs in the NAT netfilter changes. Debugging this one
> > > patch is becomming a full time job :-(

But you do it well... Looks like this fixes the slab problems here with
69-bk from Sunday am.

> > > This should fix it. Rusty, you're computing checksums and mangling
> > > src/dst using header pointers potentially pointing to free'd skbs.
> >
> > Did you mean to send a one megabyte diff?
>
> Let's try this again, here is the correct patch :-)

Thanks
Ed Tomlinson

2003-05-12 07:35:01

by David Miller

[permalink] [raw]
Subject: Re: Slab corruption mm3 + davem fixes

From: Ed Tomlinson <[email protected]>
Date: Mon, 12 May 2003 03:44:50 -0400

On May 11, 2003 06:34 pm, David S. Miller wrote:
> > > Yeah, more bugs in the NAT netfilter changes. Debugging this one
> > > patch is becomming a full time job :-(

But you do it well... Looks like this fixes the slab problems here with
69-bk from Sunday am.

Thank you for testing.