2003-05-13 15:41:10

by Richard Curnow

[permalink] [raw]
Subject: [PATCH] ehci-hcd.c needs to include <linux/bitops.h>

When I try to configure in EHCI support without this patch, I get
generic_ffs undefined at link time. (This is with 2.4.21-rc2 on our
sh64 (SH-5) port). Perhaps there are other ways to achieve this, but
this worked for me.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1212 -> 1.1213
# drivers/usb/host/ehci-hcd.c 1.12 -> 1.13
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/05/13 [email protected] 1.1213
# ehci-hcd.c needs to include <linux/bitops.h>, otherwise the inline
# definition of generic_ffs is not visible and it becomes an undefined
# symbol at link time.
# --------------------------------------------
#
diff -Nru a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
--- a/drivers/usb/host/ehci-hcd.c Tue May 13 16:50:22 2003
+++ b/drivers/usb/host/ehci-hcd.c Tue May 13 16:50:22 2003
@@ -31,6 +31,7 @@
#include <linux/list.h>
#include <linux/interrupt.h>
#include <linux/reboot.h>
+#include <linux/bitops.h> /* for generic_ffs */

#ifdef CONFIG_USB_DEBUG
#define DEBUG

--
Richard \\\ SuperH Core+Debug Architect /// .. At home ..
P. /// [email protected] /// [email protected]
Curnow \\\ http://www.superh.com/ /// http://www.rc0.org.uk
Speaking for myself, not on behalf of SuperH


2003-05-13 20:25:18

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] ehci-hcd.c needs to include <linux/bitops.h>

On Tue, May 13, 2003 at 04:53:41PM +0100, Richard Curnow wrote:
> When I try to configure in EHCI support without this patch, I get
> generic_ffs undefined at link time. (This is with 2.4.21-rc2 on our
> sh64 (SH-5) port). Perhaps there are other ways to achieve this, but
> this worked for me.

Thanks, I've added this to my tree and will send it on.

greg k-h