2003-05-18 22:08:09

by Pavel Machek

[permalink] [raw]
Subject: ioctl32 cleanups: kill code duplication

Hi!

I guess volunteers porting this to other architectures would be
welcome at this point. It should work properly at both x86-64 and
sparc64 and adding new architectures should be painless.

Please test/port ;-).

Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


Attachments:
(No filename) (317.00 B)
delme.gz (49.09 kB)
Download all attachments

2003-05-19 01:45:24

by Milton D. Miller II

[permalink] [raw]
Subject: Re: ioctl32 cleanups: kill code duplication


> +#include "../../../fs/compat_ioctl.c"

I think the kbuild people would rather you do this in the Makefile with
something like

CFLAGS_ioctl32.o += -Ifs/

and then

#include "compat_ioctl.c"

instead. I know the seperate source/obj dir people will.

milton

2003-05-19 19:08:26

by Pavel Machek

[permalink] [raw]
Subject: Re: ioctl32 cleanups: kill code duplication

Hi!

> > +#include "../../../fs/compat_ioctl.c"
>
> I think the kbuild people would rather you do this in the Makefile with
> something like
>
> CFLAGS_ioctl32.o += -Ifs/
>
> and then
>
> #include "compat_ioctl.c"
>
> instead. I know the seperate source/obj dir people will.

Applied, thanx. [Milton, you have some severe misconfiguration in your
mail system... watch your from address.]

Patch now looks like [attached]. If there are no protests I'll send it
to Linus.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


Attachments:
(No filename) (578.00 B)
delme.gz (49.29 kB)
Download all attachments