2003-05-28 06:16:11

by Milton Miller

Subject: [PATCH] copy the tag_map

Hi Jens

saw this on checkin ...

milton

===== drivers/block/ll_rw_blk.c 1.171 vs edited =====
--- 1.171/drivers/block/ll_rw_blk.c Tue May 27 15:21:00 2003
+++ edited/drivers/block/ll_rw_blk.c Wed May 28 00:43:33 2003
@@ -553,7 +553,7 @@

memcpy(bqt->tag_index, tag_index, max_depth * sizeof(struct request *));
bits = max_depth / BLK_TAGS_PER_LONG;
- memcpy(bqt->tag_map, bqt->tag_map, bits * sizeof(unsigned long));
+ memcpy(bqt->tag_map, tag_map, bits * sizeof(unsigned long));

kfree(tag_index);
kfree(tag_map);

2003-05-28 06:18:40

by Jens Axboe

Subject: Re: [PATCH] copy the tag_map

On Wed, May 28 2003, Milton Miller wrote:
>
> Hi Jens
>
> saw this on checkin ...
>
> milton
>
> ===== drivers/block/ll_rw_blk.c 1.171 vs edited =====
> --- 1.171/drivers/block/ll_rw_blk.c Tue May 27 15:21:00 2003
> +++ edited/drivers/block/ll_rw_blk.c Wed May 28 00:43:33 2003
> @@ -553,7 +553,7 @@
>
> memcpy(bqt->tag_index, tag_index, max_depth * sizeof(struct request *));
> bits = max_depth / BLK_TAGS_PER_LONG;
> - memcpy(bqt->tag_map, bqt->tag_map, bits * sizeof(unsigned long));
> + memcpy(bqt->tag_map, tag_map, bits * sizeof(unsigned long));

Ah thanks, yes obvious typo there! I'll send your fix on.

--
Jens Axboe