2003-06-03 17:45:54

by Jeff Garzik

[permalink] [raw]
Subject: Regarding SET_NETDEV_DEV

For janitors and other developers placing this in net drivers...
please don't :) This can be done in upper layers, accomplishing the
same goal without changing the low-level net driver code at all.

Jeff





2003-06-04 02:58:22

by David Miller

[permalink] [raw]
Subject: Re: Regarding SET_NETDEV_DEV

From: Jeff Garzik <[email protected]>
Date: Tue, 3 Jun 2003 13:59:21 -0400

For janitors and other developers placing this in net drivers...
please don't :) This can be done in upper layers, accomplishing the
same goal without changing the low-level net driver code at all.

Don't say something can be done without showing exactly
how :-)

How does register_netdevice() know that the device is "whatever" and
where to get the generic device struct from?

2003-06-04 03:14:27

by Jeff Garzik

[permalink] [raw]
Subject: Re: Regarding SET_NETDEV_DEV

David S. Miller wrote:
> From: Jeff Garzik <[email protected]>
> Date: Tue, 3 Jun 2003 13:59:21 -0400
>
> For janitors and other developers placing this in net drivers...
> please don't :) This can be done in upper layers, accomplishing the
> same goal without changing the low-level net driver code at all.
>
> Don't say something can be done without showing exactly
> how :-)
>
> How does register_netdevice() know that the device is "whatever" and
> where to get the generic device struct from?


Doh! You are totally right -- it can't get the association any other
way. Folks, ignore me :)

Jeff



2003-06-04 03:31:51

by Stephen Hemminger

[permalink] [raw]
Subject: Re: Regarding SET_NETDEV_DEV

David S. Miller wrote:

> From: Jeff Garzik <[email protected]>
> Date: Tue, 3 Jun 2003 13:59:21 -0400
>
> For janitors and other developers placing this in net drivers...
> please don't :) This can be done in upper layers, accomplishing the
> same goal without changing the low-level net driver code at all.
>
>Don't say something can be done without showing exactly
>how :-)
>
>How does register_netdevice() know that the device is "whatever" and
>where to get the generic device struct from?
>
There are enough PCI network devices, that something like
alloc_pci_etherdev might
be a good future idea.


2003-06-04 03:34:51

by David Miller

[permalink] [raw]
Subject: Re: Regarding SET_NETDEV_DEV

From: Stephen Hemminger <[email protected]>
Date: Tue, 03 Jun 2003 20:45:21 -0700

There are enough PCI network devices, that something like
alloc_pci_etherdev might
be a good future idea.

What is sos special about PCI? :-)

In this light, alloc_device_etherdev() seems much more appropriate.

But we can play this game AD_INFINITUM, for each and every paramter
that is common across a class of ethernet devices. At what point
do you stop? :-)