2003-06-24 17:53:17

by Adrian Bunk

[permalink] [raw]
Subject: 2.5.73: integer constants in sym53c8xx_2/sym_glue.c too big for int

The patch below postfixes a constant in sym53c8xx_2/sym_glue.c with ULL,
on 32 bit archs this constant is too big for an int.

The other problem is the PciDmaMask #if SYM_CONF_DMA_ADDRESSING_MODE == 1:
Are the _ten_ "f"'s intended (making the constant bigger than the size
of an int on 32 bit archs)?

cu
Adrian

--- linux-2.5.73-not-full/drivers/scsi/sym53c8xx_2/sym_glue.c.old 2003-06-24 19:53:04.000000000 +0200
+++ linux-2.5.73-not-full/drivers/scsi/sym53c8xx_2/sym_glue.c 2003-06-24 19:56:01.000000000 +0200
@@ -1863,7 +1863,7 @@
#if SYM_CONF_DMA_ADDRESSING_MODE == 1
#define PciDmaMask 0xffffffffff
#elif SYM_CONF_DMA_ADDRESSING_MODE == 2
-#define PciDmaMask 0xffffffffffffffff
+#define PciDmaMask 0xffffffffffffffffULL
#endif
if (np->features & FE_DAC) {
if (!pci_set_dma_mask(np->s.device, PciDmaMask)) {