2003-07-13 07:19:15

by Andrey Borzenkov

Subject: 2.5 and devfs versioning

{pts/2}% dmesg | head -1
Linux version 2.5.75-1borsmp ...

{pts/2}% dmesg | grep devfs
Kernel command line: BOOT_IMAGE=2575-1borsmp ro root=345 devfs=mount
devfs: v1.22 (20021013) Richard Gooch ([email protected])

well, this is not quite correct to put it mildly. It has been so much changed
that IMHO it needs own version just to avoid confusion.

-andrey

2003-07-13 09:10:59

by Christoph Hellwig

Subject: Re: 2.5 and devfs versioning

On Sun, Jul 13, 2003 at 11:32:46AM +0400, Andrey Borzenkov wrote:
> {pts/2}% dmesg | head -1
> Linux version 2.5.75-1borsmp ...
>
> {pts/2}% dmesg | grep devfs
> Kernel command line: BOOT_IMAGE=2575-1borsmp ro root=345 devfs=mount
> devfs: v1.22 (20021013) Richard Gooch ([email protected])
>
> well, this is not quite correct to put it mildly. It has been so much changed
> that IMHO it needs own version just to avoid confusion.

Just rip out the whole printk then. Componentes that are maintained inside
the kernel tree don't need version numbers.

2003-07-14 18:25:40

by Diego Calleja

Subject: [PATCH] Remove mtrr version printk

El Sun, 13 Jul 2003 10:25:43 +0100 Christoph Hellwig <[email protected]> escribi?:

> Just rip out the whole printk then. Componentes that are maintained inside
> the kernel tree don't need version numbers.



So I guess this would be right.


diff -puN arch/i386/kernel/cpu/mtrr/main.c~nuke_mtrrver arch/i386/kernel/cpu/mtrr/main.c
--- unsta.moo/arch/i386/kernel/cpu/mtrr/main.c~nuke_mtrrver 2003-07-14 20:29:53.000000000 +0200
+++ unsta.moo-diego/arch/i386/kernel/cpu/mtrr/main.c 2003-07-14 20:34:28.000000000 +0200
@@ -44,8 +44,6 @@
#include <asm/msr.h>
#include "mtrr.h"

-#define MTRR_VERSION "2.0 (20020519)"
-
u32 num_var_ranges = 0;

unsigned int *usage_table;
@@ -677,7 +675,6 @@ static int __init mtrr_init(void)
break;
}
}
- printk("mtrr: v%s\n",MTRR_VERSION);

if (mtrr_if) {
set_num_var_ranges();

_