Dear Alan,
The following patch would remove the obselete EXPORT_NO_SYMBOLS from some of the sources.
>From my understanding the EXPORT_NO_SYMBOLS is not needed any more as all the symbols, by default
are now kept away from being exported.
The patch is against the ac2 patched test1 kernel.
Hope it does not break anything !!
Regards
KK
===================================================
Result of ' cat patch_export_no_symbol-ac2-test1.patch | diffstat '
arch/cris/arch-v10/drivers/pcf8563.c | 1 -
drivers/net/meth.c | 1 -
sound/oss/harmony.c | 1 -
sound/oss/swarm_cs4297a.c | 1 -
4 files changed, 4 deletions(-)
===================================================
The following is the patch:
===================================================
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/arch/cris/arch-v10/drivers/pcf8563.c linux-2.6.0-test1-ac2/arch/cris/arch-v10/drivers/pcf8563.c
--- linux-2.6.0-test1-ac2.orig/arch/cris/arch-v10/drivers/pcf8563.c 2003-07-14 09:02:40.000000000 +0530
+++ linux-2.6.0-test1-ac2/arch/cris/arch-v10/drivers/pcf8563.c 2003-07-22 12:33:24.000000000 +0530
@@ -282,6 +282,5 @@
return 0;
}
-EXPORT_NO_SYMBOLS;
module_init(pcf8563_init);
module_exit(pcf8563_exit);
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/drivers/net/meth.c linux-2.6.0-test1-ac2/drivers/net/meth.c
--- linux-2.6.0-test1-ac2.orig/drivers/net/meth.c 2003-07-14 09:07:16.000000000 +0530
+++ linux-2.6.0-test1-ac2/drivers/net/meth.c 2003-07-22 12:33:54.000000000 +0530
@@ -845,7 +845,6 @@
result, meth_devs->name);
else device_present++;
#ifndef METH_DEBUG
- EXPORT_NO_SYMBOLS;
#endif
return device_present ? 0 : -ENODEV;
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/harmony.c linux-2.6.0-test1-ac2/sound/oss/harmony.c
--- linux-2.6.0-test1-ac2.orig/sound/oss/harmony.c 2003-07-22 12:29:26.000000000 +0530
+++ linux-2.6.0-test1-ac2/sound/oss/harmony.c 2003-07-22 12:38:12.000000000 +0530
@@ -1285,7 +1285,6 @@
unregister_parisc_driver(&harmony_driver);
}
-EXPORT_NO_SYMBOLS;
MODULE_AUTHOR("Alex DeVries <[email protected]>");
MODULE_DESCRIPTION("Harmony sound driver");
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/swarm_cs4297a.c linux-2.6.0-test1-ac2/sound/oss/swarm_cs4297a.c
--- linux-2.6.0-test1-ac2.orig/sound/oss/swarm_cs4297a.c 2003-07-14 09:04:39.000000000 +0530
+++ linux-2.6.0-test1-ac2/sound/oss/swarm_cs4297a.c 2003-07-22 12:36:31.000000000 +0530
@@ -90,7 +90,6 @@
#include <asm/sibyte/64bit.h>
struct cs4297a_state;
-EXPORT_NO_SYMBOLS;
static void stop_dac(struct cs4297a_state *s);
static void stop_adc(struct cs4297a_state *s);
-
On Tue, Jul 22, 2003 at 01:42:30PM +0530, Krishnakumar. R wrote:
> #ifndef METH_DEBUG
> - EXPORT_NO_SYMBOLS;
> #endif
Why not just pull the whole #ifdef/#endif?
-Josh
--
Using words to describe magic is like using a screwdriver to cut roast beef.
-- Tom Robbins
Please find the patch with the #ifndef removed.
On Tuesday 22 July 2003 13:52, Joshua Kwan wrote:
> On Tue, Jul 22, 2003 at 01:42:30PM +0530, Krishnakumar. R wrote:
> > #ifndef METH_DEBUG
> > - EXPORT_NO_SYMBOLS;
> > #endif
>
> Why not just pull the whole #ifdef/#endif?
>
> -Josh
======================================================
Output of diffstat
arch/cris/arch-v10/drivers/pcf8563.c | 1 -
drivers/net/meth.c | 3 ---
sound/oss/harmony.c | 1 -
sound/oss/swarm_cs4297a.c | 1 -
4 files changed, 6 deletions(-)
======================================================
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/arch/cris/arch-v10/drivers/pcf8563.c linux-2.6.0-test1-ac2/arch/cris/arch-v10/drivers/pcf8563.c
--- linux-2.6.0-test1-ac2.orig/arch/cris/arch-v10/drivers/pcf8563.c 2003-07-14 09:02:40.000000000 +0530
+++ linux-2.6.0-test1-ac2/arch/cris/arch-v10/drivers/pcf8563.c 2003-07-22 12:33:24.000000000 +0530
@@ -282,6 +282,5 @@
return 0;
}
-EXPORT_NO_SYMBOLS;
module_init(pcf8563_init);
module_exit(pcf8563_exit);
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/drivers/net/meth.c linux-2.6.0-test1-ac2/drivers/net/meth.c
--- linux-2.6.0-test1-ac2.orig/drivers/net/meth.c 2003-07-14 09:07:16.000000000 +0530
+++ linux-2.6.0-test1-ac2/drivers/net/meth.c 2003-07-22 14:47:51.000000000 +0530
@@ -844,9 +844,6 @@
printk("meth: error %i registering device \"%s\"\n",
result, meth_devs->name);
else device_present++;
-#ifndef METH_DEBUG
- EXPORT_NO_SYMBOLS;
-#endif
return device_present ? 0 : -ENODEV;
}
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/harmony.c linux-2.6.0-test1-ac2/sound/oss/harmony.c
--- linux-2.6.0-test1-ac2.orig/sound/oss/harmony.c 2003-07-22 12:29:26.000000000 +0530
+++ linux-2.6.0-test1-ac2/sound/oss/harmony.c 2003-07-22 12:38:12.000000000 +0530
@@ -1285,7 +1285,6 @@
unregister_parisc_driver(&harmony_driver);
}
-EXPORT_NO_SYMBOLS;
MODULE_AUTHOR("Alex DeVries <[email protected]>");
MODULE_DESCRIPTION("Harmony sound driver");
diff -urN -X dontdiff linux-2.6.0-test1-ac2.orig/sound/oss/swarm_cs4297a.c linux-2.6.0-test1-ac2/sound/oss/swarm_cs4297a.c
--- linux-2.6.0-test1-ac2.orig/sound/oss/swarm_cs4297a.c 2003-07-14 09:04:39.000000000 +0530
+++ linux-2.6.0-test1-ac2/sound/oss/swarm_cs4297a.c 2003-07-22 12:36:31.000000000 +0530
@@ -90,7 +90,6 @@
#include <asm/sibyte/64bit.h>
struct cs4297a_state;
-EXPORT_NO_SYMBOLS;
static void stop_dac(struct cs4297a_state *s);
static void stop_adc(struct cs4297a_state *s);
-