2003-07-24 18:26:58

by Balram Adlakha

Subject: devfs_remove call when not using devfs 2.6.0-test1

I get the following when I remove the OSS emu10k1 module:

Call Trace:
[<c018e261>] devfs_remove+0x9e/0xa0
[<c013898a>] unmap_vmas+0xcb/0x214
[<d29e3e2d>] oss_cleanup+0x2b/0xed [sound]
[<c0129c1e>] sys_delete_module+0x152/0x1a8
[<c0130064>] generic_file_aio_write_nolock+0x8a7/0xa6a
[<c013be3c>] sys_munmap+0x57/0x75
[<c0108f81>] sysenter_past_esp+0x52/0x71

I'm not using devfs so it should not happen.

2003-07-26 08:37:16

by Andrew Morton

Subject: Re: devfs_remove call when not using devfs 2.6.0-test1

Balram Adlakha <[email protected]> wrote:
>
> I get the following when I remove the OSS emu10k1 module:
>
> Call Trace:
> [<c018e261>] devfs_remove+0x9e/0xa0
> [<c013898a>] unmap_vmas+0xcb/0x214
> [<d29e3e2d>] oss_cleanup+0x2b/0xed [sound]
> [<c0129c1e>] sys_delete_module+0x152/0x1a8
> [<c0130064>] generic_file_aio_write_nolock+0x8a7/0xa6a
> [<c013be3c>] sys_munmap+0x57/0x75
> [<c0108f81>] sysenter_past_esp+0x52/0x71
>
> I'm not using devfs so it should not happen.

Does this fix it?

diff -puN sound/oss/soundcard.c~soundcard-devfs-fix sound/oss/soundcard.c
--- 25/sound/oss/soundcard.c~soundcard-devfs-fix 2003-07-26 01:52:55.000000000 -0700
+++ 25-akpm/sound/oss/soundcard.c 2003-07-26 01:52:59.000000000 -0700
@@ -592,7 +592,7 @@ static void __exit oss_cleanup(void)
int i, j;

for (i = 0; i < sizeof (dev_list) / sizeof *dev_list; i++) {
- devfs_remove("snd/%s", dev_list[i].name);
+ devfs_remove("sound/%s", dev_list[i].name);
if (!dev_list[i].num)
continue;
for (j = 1; j < *dev_list[i].num; j++)

_