2003-08-14 23:31:38

by Ian Wienand

[permalink] [raw]
Subject: [patch] Problems building drivers/scsi/qla1280.c in BK current

Hi,

When building I got a failure :

drivers/scsi/qla1280.c: In function `qla1280_done':
drivers/scsi/qla1280.c:1833: warning: implicit declaration of function `qla1280_get_target_options'
drivers/scsi/qla1280.c: At top level:
drivers/scsi/qla1280.c:4506: warning: type mismatch with previous implicit declaration
drivers/scsi/qla1280.c:1833: warning: previous implicit declaration of `qla1280_get_target_options'
drivers/scsi/qla1280.c:4506: warning: `qla1280_get_target_options' was previously implicitly declared to return `int'
drivers/scsi/qla1280.c:4830: warning: initialization from incompatible pointer type
drivers/scsi/qla1280.c:4830: error: unknown field `command' specified in initializer
drivers/scsi/sym53c8xx_2/sym_glue.c: In function `sym53c8xx_pci_init':
drivers/scsi/sym53c8xx_2/sym_glue.c:2323: warning: `check_region' is deprecated (declared at include/linux/ioport.h:117)
make[2]: *** [drivers/scsi/qla1280.o] Error 1

qla1280.c seems to use LINUX_KERNEL_VERSION where I think it really
wants LINUX_VERSION_CODE. While I was there I changed the other
checks to use the KERNEL_VERSION macro.

I also changed the blk.h include because it says :
In file included from drivers/scsi/qla1280.c:299:
include/linux/blk.h:1:2: warning: #warning this file is obsolete, please use linux/blkdev.h instead

Also I required the attached change to qla1280.h

-i
[email protected]
http://www.gelato.unsw.edu.au


Attachments:
(No filename) (1.39 kB)
qla1280.c.diff (5.27 kB)
qla1280.h.diff (400.00 B)
Download all attachments