2003-08-19 06:41:03

by CaT

[permalink] [raw]
Subject: [PATCH 6/10] 2.6.0-t3: struct C99 initialiser conversion

linux/drivers/ patch

--
"How can I not love the Americans? They helped me with a flat tire the
other day," he said.
- http://tinyurl.com/h6fo


Attachments:
(No filename) (145.00 B)
2.6.0-t3.c99.drivers.patch (28.13 kB)
Download all attachments

2003-08-19 17:36:12

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 6/10] 2.6.0-t3: struct C99 initialiser conversion

On Tue, Aug 19, 2003 at 04:37:27PM +1000, CaT wrote:
> diff -aur linux.backup/drivers/usb/host/hc_sl811_rh.c linux/drivers/usb/host/hc_sl811_rh.c
> --- linux.backup/drivers/usb/host/hc_sl811_rh.c Sat Aug 16 15:02:54 2003
> +++ linux/drivers/usb/host/hc_sl811_rh.c Sat Aug 16 23:57:09 2003
> @@ -329,7 +329,7 @@
> switch (bmRType_bReq) {
> /* Request Destination:
> without flags: Device,
> - RH_INTERFACE: interface,
> + RH_INTERFACE: interface,
> RH_ENDPOINT: endpoint,
> RH_CLASS means HUB here,
> RH_OTHER | RH_CLASS almost ever means HUB_PORT here

I think you need to work on your scripts if you thought this was a C99
"fix". More like a "delete trailing space" patch...

thanks,

greg k-h

2003-08-19 18:16:45

by CaT

[permalink] [raw]
Subject: Re: [PATCH 6/10] 2.6.0-t3: struct C99 initialiser conversion

On Tue, Aug 19, 2003 at 10:23:55AM -0700, Greg KH wrote:
> On Tue, Aug 19, 2003 at 04:37:27PM +1000, CaT wrote:
> > @@ -329,7 +329,7 @@
> > switch (bmRType_bReq) {
> > /* Request Destination:
> > without flags: Device,
> > - RH_INTERFACE: interface,
> > + RH_INTERFACE: interface,
> > RH_ENDPOINT: endpoint,
> > RH_CLASS means HUB here,
> > RH_OTHER | RH_CLASS almost ever means HUB_PORT here
>
> I think you need to work on your scripts if you thought this was a C99
> "fix". More like a "delete trailing space" patch...

That it is. I was aware of it but I didn't think leaving it there would
hurt... But I'll take it out of the -bk6 patch.

--
"How can I not love the Americans? They helped me with a flat tire the
other day," he said.
- http://tinyurl.com/h6fo