2003-08-23 13:33:15

by Vinay K Nallamothu

Subject: [PATCH 2.6.0-test4] wait.h: fix spin_lock_irqrestore typo

Hi Linus,

A small patch to fix a spin_lock typo in the macro add_wait_queue_cond

Vinay

--- linux-2.6.0-test4/include/linux/wait.h 2003-07-15 17:22:56.000000000 +0530
+++ linux-2.6.0-test4-nvk/include/linux/wait.h 2003-08-23 19:08:36.000000000 +0530
@@ -232,7 +232,7 @@
_raced = 1; \
__remove_wait_queue((q), (wait)); \
} \
- spin_lock_irqrestore(&(q)->lock, flags); \
+ spin_unlock_irqrestore(&(q)->lock, flags); \
_raced; \
})

2003-08-23 22:15:53

by Andrew Morton

Subject: Re: [PATCH 2.6.0-test4] wait.h: fix spin_lock_irqrestore typo

Vinay K Nallamothu <[email protected]> wrote:
>
> A small patch to fix a spin_lock typo in the macro add_wait_queue_cond
>
> Vinay
>
> --- linux-2.6.0-test4/include/linux/wait.h 2003-07-15 17:22:56.000000000 +0530
> +++ linux-2.6.0-test4-nvk/include/linux/wait.h 2003-08-23 19:08:36.000000000 +0530
> @@ -232,7 +232,7 @@
> _raced = 1; \
> __remove_wait_queue((q), (wait)); \
> } \
> - spin_lock_irqrestore(&(q)->lock, flags); \
> + spin_unlock_irqrestore(&(q)->lock, flags); \
> _raced; \
> })

Well that's obviously had a lot of testing.

It has no callers; I'll just kill it.