2003-08-27 07:12:29

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] fix bpqether.c compile without CONFIG_PROC_FS

I got the following compile error when trying to compile 2.6.0-test4-mm1
without CONFIG_PROC_FS (but this problem is most likely not limited to
-mm):

<-- snip -->

...
CC drivers/net/hamradio/bpqether.o
drivers/net/hamradio/bpqether.c: In function `bpq_init_driver':
drivers/net/hamradio/bpqether.c:608: parse error before `do'
...
make[3]: *** [drivers/net/hamradio/bpqether.o] Error 1

<-- snip -->


It seems something like the following patch is needed:


--- linux-2.6.0-test4-mm1/drivers/net/hamradio/bpqether.c~ 2003-08-23 01:55:31.000000000 +0200
+++ linux-2.6.0-test4-mm1/drivers/net/hamradio/bpqether.c 2003-08-27 09:00:04.000000000 +0200
@@ -605,6 +605,7 @@

printk(banner);

+#ifdef CONFIG_PROC_FS
if (!proc_net_fops_create("bpqether", S_IRUGO, &bpq_info_fops)) {
printk(KERN_ERR
"bpq: cannot create /proc/net/bpqether entry.\n");
@@ -612,6 +613,7 @@
dev_remove_pack(&bpq_packet_type);
return -ENOENT;
}
+#endif /* CONFIG_PROC_FS */

rtnl_lock();
for (dev = dev_base; dev != NULL; dev = dev->next) {



cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2003-08-28 06:51:46

by David Miller

[permalink] [raw]
Subject: Re: [2.6 patch] fix bpqether.c compile without CONFIG_PROC_FS

On Wed, 27 Aug 2003 09:12:15 +0200
Adrian Bunk <[email protected]> wrote:

> I got the following compile error when trying to compile 2.6.0-test4-mm1
> without CONFIG_PROC_FS (but this problem is most likely not limited to
> -mm):

Applied, thanks.