2003-08-25 21:34:02

by CIJOML

[permalink] [raw]
Subject: Can't compile 2.6.0-test4

Hi,

I tried compile 2.6.0-test4, but I got this error messages:
gcc-3.3, Debian Woody with bunk debs

arch/i386/mm/built-in.o(.init.text+0x4bf): In function `mem_init':
: undefined reference to `kclist_add'
arch/i386/mm/built-in.o(.init.text+0x4ec): In function `mem_init':
: undefined reference to `kclist_add'
make: *** [.tmp_vmlinux1] Error 1

.config included

Michal


Attachments:
(No filename) (373.00 B)
config-experimental-2.6.bz2 (6.22 kB)
Download all attachments

2003-08-26 10:51:56

by Adrian Bunk

[permalink] [raw]
Subject: 2.6.0-test4: CONFIG_KCORE_AOUT doesn't compile

On Mon, Aug 25, 2003 at 11:32:46PM +0200, Michal Semler (volny.cz) wrote:
> Hi,
>
> I tried compile 2.6.0-test4, but I got this error messages:
> gcc-3.3, Debian Woody with bunk debs
>
> arch/i386/mm/built-in.o(.init.text+0x4bf): In function `mem_init':
> : undefined reference to `kclist_add'
> arch/i386/mm/built-in.o(.init.text+0x4ec): In function `mem_init':
> : undefined reference to `kclist_add'
> make: *** [.tmp_vmlinux1] Error 1
>
> .config included

@Michal:

# CONFIG_KCORE_ELF is not set
CONFIG_KCORE_AOUT=y


I assume you want to change
Executable file formats
Kernel core (/proc/kcore) format
to
ELF


@all:

Is there any specific reason to keep CONFIG_KCORE_AOUT or is it time to
remove this option?



> Michal

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2003-08-26 12:30:57

by CIJOML

[permalink] [raw]
Subject: Re: 2.6.0-test4: CONFIG_KCORE_AOUT doesn't compile

Thanks for helping me.
Kernel got compiled now, but not boot.

It gets into maintaince wanting root password and then telling me:

QM_MODULES - function not implemented.

What need I switch on to get modules working?

Michal

Dne ?t 26. srpna 2003 12:51 jste napsal(a):
> On Mon, Aug 25, 2003 at 11:32:46PM +0200, Michal Semler (volny.cz) wrote:
> > Hi,
> >
> > I tried compile 2.6.0-test4, but I got this error messages:
> > gcc-3.3, Debian Woody with bunk debs
> >
> > arch/i386/mm/built-in.o(.init.text+0x4bf): In function `mem_init':
> > : undefined reference to `kclist_add'
> >
> > arch/i386/mm/built-in.o(.init.text+0x4ec): In function `mem_init':
> > : undefined reference to `kclist_add'
> >
> > make: *** [.tmp_vmlinux1] Error 1
> >
> > .config included
>
> @Michal:
>
> # CONFIG_KCORE_ELF is not set
> CONFIG_KCORE_AOUT=y
>
>
> I assume you want to change
> Executable file formats
> Kernel core (/proc/kcore) format
> to
> ELF
>
>
> @all:
>
> Is there any specific reason to keep CONFIG_KCORE_AOUT or is it time to
> remove this option?
>
> > Michal
>
> cu
> Adrian

2003-08-26 12:33:23

by Adrian Bunk

[permalink] [raw]
Subject: Re: 2.6.0-test4: CONFIG_KCORE_AOUT doesn't compile

On Tue, Aug 26, 2003 at 02:28:07PM +0200, Michal Semler (volny.cz) wrote:

> Thanks for helping me.
> Kernel got compiled now, but not boot.
>
> It gets into maintaince wanting root password and then telling me:
>
> QM_MODULES - function not implemented.
>
> What need I switch on to get modules working?

Did you install the module-init-tools package?

> Michal

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2003-08-26 15:48:22

by CIJOML

[permalink] [raw]
Subject: 2.6.0-test4 and /etc/modules.conf

Hi,

I have in /etc/modules.conf defined which modules to use. 2.4.22 uses it well,
but 2.6.0-test4 doesn't.

I tried add these defs into /etc/modprobe.d/aliases but without success.

When I by hand call for example modprobe hid module is loaded and device
works.

Can somebody help me?

Michal

2003-08-26 15:59:37

by Bas Mevissen

[permalink] [raw]
Subject: Re: 2.6.0-test4 and /etc/modules.conf

Michal Semler (volny.cz) wrote:

> Hi,
>
> I have in /etc/modules.conf defined which modules to use. 2.4.22 uses it well,
> but 2.6.0-test4 doesn't.
>
> I tried add these defs into /etc/modprobe.d/aliases but without success.
>

In 2.6, the file /etc/modprobe.conf is used. When you use Red Hat, you
can install their modutils package from RawHide, that creates that file
from your /etc/modules.conf file.

There is probably some util around that creates the file for you. This
issue is documented in the FAQ in the modutils source.

> When I by hand call for example modprobe hid module is loaded and
> device works.

This means that you already got the proper modutils version installed.

Regards,

Bas.




2003-08-26 16:37:42

by CIJOML

[permalink] [raw]
Subject: Re: 2.6.0-test4 and /etc/modules.conf

Dne ?t 26. srpna 2003 18:00 jste napsal(a):
> Michal Semler (volny.cz) wrote:
> > Hi,
> >
> > I have in /etc/modules.conf defined which modules to use. 2.4.22 uses it
> > well, but 2.6.0-test4 doesn't.
> >
> > I tried add these defs into /etc/modprobe.d/aliases but without success.
>
> In 2.6, the file /etc/modprobe.conf is used. When you use Red Hat, you
> can install their modutils package from RawHide, that creates that file
> from your /etc/modules.conf file.

Hmm I use Debian - is there any util for this distro?

>
> There is probably some util around that creates the file for you. This
> issue is documented in the FAQ in the modutils source.
>
> > When I by hand call for example modprobe hid module is loaded and
> > device works.
>
> This means that you already got the proper modutils version installed.
>
> Regards,
>
> Bas.

2003-08-26 17:39:17

by Emmanuele Bassi

[permalink] [raw]
Subject: Re: 2.6.0-test4 and /etc/modules.conf

* Michal Semler (volny.cz) <[email protected]>:

Hi,

> > In 2.6, the file /etc/modprobe.conf is used. When you use Red Hat, you
> > can install their modutils package from RawHide, that creates that file
> > from your /etc/modules.conf file.
>
> Hmm I use Debian - is there any util for this distro?

Inside the module-init-tools package, there's:

/usr/share/doc/module-init-tools/examples/generate-modprobe.conf.gz

Regards,
Emmanuele.

--
Emmanuele Bassi (Zefram) [ http://digilander.libero.it/ebassi/ ]
GnuPG Key fingerprint = 4DD0 C90D 4070 F071 5738 08BD 8ECC DB8F A432 0FF4

2003-08-26 19:16:08

by Felipe Alfaro Solana

[permalink] [raw]
Subject: Re: 2.6.0-test4 and /etc/modules.conf

On Tue, 2003-08-26 at 17:48, Michal Semler (volny.cz) wrote:

> I have in /etc/modules.conf defined which modules to use. 2.4.22 uses it well,
> but 2.6.0-test4 doesn't.

I assume you are using the corresponding updated modutils package that
is compatible with 2.6 kernels. This new modutils package uses
/etc/modprobe.conf instead of the old /etc/modules.conf.

Since both files are almost compatible, you can safely copy the contents
of /etc/modules.conf to /etc/modprobe.conf.

2003-08-26 21:09:57

by Andrew Morton

[permalink] [raw]
Subject: Re: 2.6.0-test4: CONFIG_KCORE_AOUT doesn't compile

Adrian Bunk <[email protected]> wrote:
>
> Is there any specific reason to keep CONFIG_KCORE_AOUT or is it time to
> remove this option?

Time to kill it I suspect.

This fixes the linkage problem:


diff -puN include/linux/proc_fs.h~kcore-aout-build-fix include/linux/proc_fs.h
--- 25/include/linux/proc_fs.h~kcore-aout-build-fix Tue Aug 26 13:29:07 2003
+++ 25-akpm/include/linux/proc_fs.h Tue Aug 26 13:29:07 2003
@@ -182,12 +182,6 @@ static inline void proc_net_remove(const
remove_proc_entry(name,proc_net);
}

-/*
- * fs/proc/kcore.c
- */
-extern void kclist_add(struct kcore_list *, void *, size_t);
-extern struct kcore_list *kclist_del(void *);
-
#else

#define proc_root_driver NULL
@@ -223,6 +217,9 @@ static inline void proc_tty_unregister_d

extern struct proc_dir_entry proc_root;

+#endif /* CONFIG_PROC_FS */
+
+#if !defined(CONFIG_PROC_FS) || defined(CONFIG_KCORE_AOUT)
static inline void kclist_add(struct kcore_list *new, void *addr, size_t size)
{
}
@@ -230,8 +227,10 @@ static inline struct kcore_list * kclist
{
return NULL;
}
-
-#endif /* CONFIG_PROC_FS */
+#else
+extern void kclist_add(struct kcore_list *, void *, size_t);
+extern struct kcore_list *kclist_del(void *);
+#endif

struct proc_inode {
struct task_struct *task;

_

2003-08-30 07:08:47

by Andrew Morton

[permalink] [raw]
Subject: Re: [2.6 patch] kill CONFIG_KCORE_AOUT

Adrian Bunk <[email protected]> wrote:
>
> The patch below kills CONFIG_KCORE_AOUT.
>
> I've tested the compilation with 2.6.0-test4.

Not on m68knommu or h8300 you haven't :) They both
select CONFIG_KCORE_AOUT in defconfig.

2003-08-30 07:05:49

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] kill CONFIG_KCORE_AOUT

On Tue, Aug 26, 2003 at 01:53:23PM -0700, Andrew Morton wrote:
> Adrian Bunk <[email protected]> wrote:
> >
> > Is there any specific reason to keep CONFIG_KCORE_AOUT or is it time to
> > remove this option?
>
> Time to kill it I suspect.
>...

The patch below kills CONFIG_KCORE_AOUT.

I've tested the compilation with 2.6.0-test4.

diffstat output:

arch/alpha/Kconfig | 34 ----------------------
arch/arm/Kconfig | 33 ---------------------
arch/arm26/Kconfig | 33 ---------------------
arch/h8300/Kconfig | 7 ----
arch/i386/Kconfig | 34 ----------------------
arch/ia64/Kconfig | 23 ---------------
arch/m68k/Kconfig | 34 ----------------------
arch/m68knommu/Kconfig | 8 -----
arch/mips/Kconfig | 25 ----------------
arch/parisc/Kconfig | 5 ---
arch/ppc/Kconfig | 16 ----------
arch/ppc64/Kconfig | 16 ----------
arch/s390/Kconfig | 4 --
arch/sh/Kconfig | 34 ----------------------
arch/sparc/Kconfig | 23 ---------------
arch/sparc64/Kconfig | 23 ---------------
arch/v850/Kconfig | 8 -----
arch/x86_64/Kconfig | 5 ---
fs/proc/kcore.c | 68 ---------------------------------------------
19 files changed, 1 insertion(+), 432 deletions(-)


cu
Adrian

--- linux-2.6.0-test4-not-full/arch/i386/Kconfig.old 2003-08-30 08:32:28.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/i386/Kconfig 2003-08-30 08:34:57.000000000 +0200
@@ -1156,40 +1156,6 @@

menu "Executable file formats"

-choice
- prompt "Kernel core (/proc/kcore) format"
- depends on PROC_FS
- default KCORE_ELF
-
-config KCORE_ELF
- bool "ELF"
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool "A.OUT"
- help
- Not necessary unless you're using a very out-of-date binutils
- version. You probably want KCORE_ELF.
-
-endchoice
-
source "fs/Kconfig.binfmt"

endmenu
--- linux-2.6.0-test4-not-full/arch/mips/Kconfig.old 2003-08-30 08:34:00.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/mips/Kconfig 2003-08-30 08:35:14.000000000 +0200
@@ -1126,31 +1126,6 @@

menu "Executable file formats"

-config KCORE_ELF
- bool
- default y
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool
-
source "fs/Kconfig.binfmt"

config TRAD_SIGNALS
--- linux-2.6.0-test4-not-full/arch/m68knommu/Kconfig.old 2003-08-30 08:35:44.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/m68knommu/Kconfig 2003-08-30 08:36:01.000000000 +0200
@@ -490,14 +490,6 @@

menu "Executable file formats"

-config KCORE_AOUT
- bool
- default y
-
-config KCORE_ELF
- bool
- default y
-
source "fs/Kconfig.binfmt"

endmenu
--- linux-2.6.0-test4-not-full/arch/sh/Kconfig.old 2003-08-30 08:36:25.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/sh/Kconfig 2003-08-30 08:36:46.000000000 +0200
@@ -729,40 +729,6 @@

menu "Executable file formats"

-choice
- prompt "Kernel core (/proc/kcore) format"
- depends on PROC_FS
- default KCORE_ELF
-
-config KCORE_ELF
- bool "ELF"
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool "A.OUT"
- help
- Not necessary unless you're using a very out-of-date binutils
- version. You probably want KCORE_ELF.
-
-endchoice
-
source "fs/Kconfig.binfmt"

endmenu
--- linux-2.6.0-test4-not-full/arch/arm26/Kconfig.old 2003-08-30 08:37:09.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/arm26/Kconfig 2003-08-30 08:37:23.000000000 +0200
@@ -146,39 +146,6 @@
You may say N here if you are going to load the Acorn FPEmulator
early in the bootup.

-choice
- prompt "Kernel core (/proc/kcore) format"
- default KCORE_ELF
-
-config KCORE_ELF
- bool "ELF"
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool "A.OUT"
- help
- Not necessary unless you're using a very out-of-date binutils
- version. You probably want KCORE_ELF.
-
-endchoice
-
source "fs/Kconfig.binfmt"

config PREEMPT
--- linux-2.6.0-test4-not-full/arch/m68k/Kconfig.old 2003-08-30 08:37:43.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/m68k/Kconfig 2003-08-30 08:37:56.000000000 +0200
@@ -342,40 +342,6 @@

menu "General setup"

-choice
- prompt "Kernel core (/proc/kcore) format"
- depends on PROC_FS
- default KCORE_ELF
-
-config KCORE_ELF
- bool "ELF"
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool "A.OUT"
- help
- Not necessary unless you're using a very out-of-date binutils
- version. You probably want KCORE_ELF.
-
-endchoice
-
source "fs/Kconfig.binfmt"

config ZORRO
--- linux-2.6.0-test4-not-full/arch/alpha/Kconfig.old 2003-08-30 08:38:17.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/alpha/Kconfig 2003-08-30 08:38:36.000000000 +0200
@@ -597,40 +597,6 @@

source "drivers/pcmcia/Kconfig"

-choice
- prompt "Kernel core (/proc/kcore) format"
- depends on PROC_FS
- default KCORE_ELF
-
-config KCORE_ELF
- bool "ELF"
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool "A.OUT"
- help
- Not necessary unless you're using a very out-of-date binutils
- version. You probably want KCORE_ELF.
-
-endchoice
-
config SRM_ENV
tristate "SRM environment through procfs"
depends on PROC_FS
--- linux-2.6.0-test4-not-full/arch/arm/Kconfig.old 2003-08-30 08:39:02.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/arm/Kconfig 2003-08-30 08:39:15.000000000 +0200
@@ -654,39 +654,6 @@
If you do not feel you need a faster FP emulation you should better
choose NWFPE.

-choice
- prompt "Kernel core (/proc/kcore) format"
- default KCORE_ELF
-
-config KCORE_ELF
- bool "ELF"
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
-config KCORE_AOUT
- bool "A.OUT"
- help
- Not necessary unless you're using a very out-of-date binutils
- version. You probably want KCORE_ELF.
-
-endchoice
-
source "fs/Kconfig.binfmt"

source "drivers/base/Kconfig"
--- linux-2.6.0-test4-not-full/arch/h8300/Kconfig.old 2003-08-30 08:39:40.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/h8300/Kconfig 2003-08-30 08:40:02.000000000 +0200
@@ -177,13 +177,6 @@

menu "Executable file formats"

-config KCORE_AOUT
- bool
- default y
-
-config KCORE_ELF
- default y
-
source "fs/Kconfig.binfmt"

endmenu
--- linux-2.6.0-test4-not-full/arch/v850/Kconfig.old 2003-08-30 08:40:22.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/v850/Kconfig 2003-08-30 08:40:35.000000000 +0200
@@ -262,14 +262,6 @@

menu "Executable file formats"

-config KCORE_AOUT
- bool
- default y
-
-config KCORE_ELF
- bool
- default y
-
source "fs/Kconfig.binfmt"

endmenu
--- linux-2.6.0-test4-not-full/fs/proc/kcore.c.old 2003-08-30 08:41:11.000000000 +0200
+++ linux-2.6.0-test4-not-full/fs/proc/kcore.c 2003-08-30 08:41:55.000000000 +0200
@@ -1,5 +1,5 @@
/*
- * fs/proc/kcore.c kernel ELF/AOUT core dumper
+ * fs/proc/kcore.c kernel ELF core dumper
*
* Modelled on fs/exec.c:aout_core_dump()
* Jeremy Fitzhardinge <[email protected]>
@@ -34,71 +34,6 @@
.open = open_kcore,
};

-#ifdef CONFIG_KCORE_AOUT
-static ssize_t read_kcore(struct file *file, char *buf, size_t count, loff_t *ppos)
-{
- unsigned long long p = *ppos, memsize;
- ssize_t read;
- ssize_t count1;
- char * pnt;
- struct user dump;
-#if defined (__i386__) || defined (__mc68000__) || defined(__x86_64__)
-# define FIRST_MAPPED PAGE_SIZE /* we don't have page 0 mapped on x86.. */
-#else
-# define FIRST_MAPPED 0
-#endif
-
- memset(&dump, 0, sizeof(struct user));
- dump.magic = CMAGIC;
- dump.u_dsize = (virt_to_phys(high_memory) >> PAGE_SHIFT);
-#if defined (__i386__) || defined(__x86_64__)
- dump.start_code = PAGE_OFFSET;
-#endif
-#ifdef __alpha__
- dump.start_data = PAGE_OFFSET;
-#endif
-
- memsize = virt_to_phys(high_memory);
- if (p >= memsize)
- return 0;
- if (count > memsize - p)
- count = memsize - p;
- read = 0;
-
- if (p < sizeof(struct user) && count > 0) {
- count1 = count;
- if (p + count1 > sizeof(struct user))
- count1 = sizeof(struct user)-p;
- pnt = (char *) &dump + p;
- if (copy_to_user(buf,(void *) pnt, count1))
- return -EFAULT;
- buf += count1;
- p += count1;
- count -= count1;
- read += count1;
- }
-
- if (count > 0 && p < PAGE_SIZE + FIRST_MAPPED) {
- count1 = PAGE_SIZE + FIRST_MAPPED - p;
- if (count1 > count)
- count1 = count;
- if (clear_user(buf, count1))
- return -EFAULT;
- buf += count1;
- p += count1;
- count -= count1;
- read += count1;
- }
- if (count > 0) {
- if (copy_to_user(buf, (void *) (PAGE_OFFSET+p-PAGE_SIZE), count))
- return -EFAULT;
- read += count;
- }
- *ppos += read;
- return read;
-}
-#else /* CONFIG_KCORE_AOUT */
-
#ifndef kc_vaddr_to_offset
#define kc_vaddr_to_offset(v) ((v) - PAGE_OFFSET)
#endif
@@ -480,4 +415,3 @@

return acc;
}
-#endif /* CONFIG_KCORE_AOUT */
--- linux-2.6.0-test4-not-full/arch/sparc64/Kconfig.old 2003-08-30 08:42:56.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/sparc64/Kconfig 2003-08-30 08:43:13.000000000 +0200
@@ -363,29 +363,6 @@
<file:Documentation/modules.txt>.
The module will be called openpromfs. If unsure, say M.

-config KCORE_ELF
- bool
- depends on PROC_FS
- default y
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
config SPARC32_COMPAT
bool "Kernel support for Linux/Sparc 32bit binary compatibility"
help
--- linux-2.6.0-test4-not-full/arch/sparc/Kconfig.old 2003-08-30 08:43:35.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/sparc/Kconfig 2003-08-30 08:43:50.000000000 +0200
@@ -254,29 +254,6 @@
<file:Documentation/modules.txt>.
The module will be called openpromfs. If unsure, say M.

-config KCORE_ELF
- bool
- depends on PROC_FS
- default y
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
source "fs/Kconfig.binfmt"

config SUNOS_EMUL
--- linux-2.6.0-test4-not-full/arch/ppc/Kconfig.old 2003-08-30 08:44:56.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/ppc/Kconfig 2003-08-30 08:45:31.000000000 +0200
@@ -795,22 +795,6 @@
bool "PCI for Permedia2"
depends on !4xx && !8xx && APUS

-# only elf supported, a.out is not -- Cort
-config KCORE_ELF
- bool
- depends on PROC_FS
- default y
- help
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image in ELF format. This
- can be used in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel.
-
config KERNEL_ELF
bool
default y
--- linux-2.6.0-test4-not-full/arch/ia64/Kconfig.old 2003-08-30 08:46:04.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/ia64/Kconfig 2003-08-30 08:46:18.000000000 +0200
@@ -297,29 +297,6 @@
If you are compiling a kernel that will run under SGI's IA-64
simulator (Medusa) then say Y, otherwise say N.

-# On IA-64, we always want an ELF /proc/kcore.
-config KCORE_ELF
- bool
- default y
- ---help---
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image. This can be used
- in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- You have two choices here: ELF and A.OUT. Selecting ELF will make
- /proc/kcore appear in ELF core format as defined by the Executable
- and Linking Format specification. Selecting A.OUT will choose the
- old "a.out" format which may be necessary for some old versions
- of binutils or on some architectures.
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel so if you
- don't understand what this means or are not a kernel hacker, just
- leave it at its default value ELF.
-
config FORCE_MAX_ZONEORDER
int
default "18"
--- linux-2.6.0-test4-not-full/arch/ppc64/Kconfig.old 2003-08-30 08:46:52.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/ppc64/Kconfig 2003-08-30 08:47:03.000000000 +0200
@@ -175,22 +175,6 @@
bool
default PCI

-# only elf supported, a.out is not -- Cort
-config KCORE_ELF
- bool
- depends on PROC_FS
- default y
- help
- If you enabled support for /proc file system then the file
- /proc/kcore will contain the kernel core image in ELF format. This
- can be used in gdb:
-
- $ cd /usr/src/linux ; gdb vmlinux /proc/kcore
-
- This is especially useful if you have compiled the kernel with the
- "-g" option to preserve debugging information. It is mainly used
- for examining kernel data structures on the live kernel.
-
source "fs/Kconfig.binfmt"

source "drivers/pci/Kconfig"
--- linux-2.6.0-test4-not-full/arch/parisc/Kconfig.old 2003-08-30 08:47:39.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/parisc/Kconfig 2003-08-30 08:47:51.000000000 +0200
@@ -161,11 +161,6 @@

menu "Executable file formats"

-config KCORE_ELF
- bool
- depends on PROC_FS
- default y
-
source "fs/Kconfig.binfmt"

endmenu
--- linux-2.6.0-test4-not-full/arch/x86_64/Kconfig.old 2003-08-30 08:48:11.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/x86_64/Kconfig 2003-08-30 08:48:27.000000000 +0200
@@ -370,11 +370,6 @@

menu "Executable file formats / Emulations"

-config KCORE_ELF
- bool
- depends on PROC_FS
- default y
-
source "fs/Kconfig.binfmt"

config IA32_EMULATION
--- linux-2.6.0-test4-not-full/arch/s390/Kconfig.old 2003-08-30 08:48:55.000000000 +0200
+++ linux-2.6.0-test4-not-full/arch/s390/Kconfig 2003-08-30 08:49:08.000000000 +0200
@@ -217,10 +217,6 @@

endchoice

-config KCORE_ELF
- bool
- default y
-
source "fs/Kconfig.binfmt"

config PROCESS_DEBUG

2003-08-30 07:26:14

by Andrew Morton

[permalink] [raw]
Subject: Re: [2.6 patch] kill CONFIG_KCORE_AOUT

Adrian Bunk <[email protected]> wrote:
>
> On Sat, Aug 30, 2003 at 12:11:59AM -0700, Andrew Morton wrote:
> > Adrian Bunk <[email protected]> wrote:
> > >
> > > The patch below kills CONFIG_KCORE_AOUT.
> > >
> > > I've tested the compilation with 2.6.0-test4.
> >
> > Not on m68knommu or h8300 you haven't :) They both
> > select CONFIG_KCORE_AOUT in defconfig.
>
> The Kconfig files on these architectures had the interesting "feature"
> that both KCORE_AOUT and KCORE_ELF were enabled unconditionally...

heh. Certainly it would be nice to actually delete something for once.
It's just a matter of checking with everyone. I'll hang onto your patch
and ask around. Thanks.

2003-08-30 07:21:07

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.6 patch] kill CONFIG_KCORE_AOUT

On Sat, Aug 30, 2003 at 12:11:59AM -0700, Andrew Morton wrote:
> Adrian Bunk <[email protected]> wrote:
> >
> > The patch below kills CONFIG_KCORE_AOUT.
> >
> > I've tested the compilation with 2.6.0-test4.
>
> Not on m68knommu or h8300 you haven't :) They both
> select CONFIG_KCORE_AOUT in defconfig.

The Kconfig files on these architectures had the interesting "feature"
that both KCORE_AOUT and KCORE_ELF were enabled unconditionally...

Besides, I always consider the defconfig files as some kinds of
generated files and since they only give default answers for
"make defconfig" I didn't see the big need for manually editing every
single defconfig file.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed