Hello!
I have attached a trivial patch to the Linux 2.4.21 kernel (Debian
unstable kernel-source-2.4.21 package version 2.4.21-5), to add support
for "VIA Technologies, Inc. VT8231" as an interrupt router. I have also
attached the output of lspci -vvv (not inline because of line breaks, is
that OK?). Device 00:08.0, which did not have any IRQs assigned to it
before, has gotten IRQ 9. I have used this patch for months without any
problems, so it should be fine. Sorry if I have left out something
important; please consider me a newbie.
Here is the output of the ver_linux script:
------------------------------------------------------------------------
Linux SebastianL2 2.4.21 #1 Sat Aug 30 00:22:04 CEST 2003 i686 GNU/Linux
Gnu C 3.3.2
Gnu make 3.80
binutils 2.14.90.0.5
util-linux 2.11z
mount 2.11z
modutils 0.9.13
e2fsprogs 1.35-WIP
pcmcia-cs 3.2.2
Linux C Library 2.3.2
Dynamic linker (ldd) 2.3.2
Procps 3.1.11
Net-tools 1.60
Console-tools 0.2.3
Sh-utils 5.0.90
------------------------------------------------------------------------
If I am supposed to do something else with the patch (mail it to
Linus?), please tell me. Thanks for your attention.
--
Sebastian Reichelt
Sebastian Reichelt wrote:
> Hello!
>
> I have attached a trivial patch to the Linux 2.4.21 kernel (Debian
> unstable kernel-source-2.4.21 package version 2.4.21-5), to add support
> for "VIA Technologies, Inc. VT8231" as an interrupt router. I have also
> attached the output of lspci -vvv (not inline because of line breaks, is
> that OK?). Device 00:08.0, which did not have any IRQs assigned to it
> before, has gotten IRQ 9. I have used this patch for months without any
> problems, so it should be fine. Sorry if I have left out something
> important; please consider me a newbie.
[...]
> --- pci-irq.c.orig 2003-06-01 05:06:21.000000000 +0200
> +++ pci-irq.c 2003-08-30 00:17:42.000000000 +0200
> @@ -480,6 +480,7 @@
> { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, pirq_via_get, pirq_via_set },
> { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C596, pirq_via_get, pirq_via_set },
> { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, pirq_via_get, pirq_via_set },
> + { "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8231, pirq_via_get, pirq_via_set },
>
> { "OPTI", PCI_VENDOR_ID_OPTI, PCI_DEVICE_ID_OPTI_82C700, pirq_opti_get, pirq_opti_set },
Well, Mr. Newbie, your patch looks fine to me :)
I'll test it out locally, and make sure it gets into 2.4 and 2.6, if
nobody beats me to it.
Jeff
> Well, Mr. Newbie, your patch looks fine to me :)
Good :-)
I did forget one thing, though: It's the file pci-irq.c in
arch/i386/kernel. Well, there are only three files with this name in
2.4, but I just thought I'd mention it. ;-)
> I'll test it out locally, and make sure it gets into 2.4 and 2.6, if
> nobody beats me to it.
That's cool! Thank you so much for spending your time on things like
these!
--
Sebastian Reichelt
On Sat, Aug 30, 2003 at 08:16:54PM +0200, Sebastian Reichelt wrote:
> > Well, Mr. Newbie, your patch looks fine to me :)
>
> Good :-)
> I did forget one thing, though: It's the file pci-irq.c in
> arch/i386/kernel. Well, there are only three files with this name in
> 2.4, but I just thought I'd mention it. ;-)
Then run patch from the root of the kernel tree next time, there will be no
confusion at all.