2003-09-15 21:31:15

by Marcelo Tosatti

[permalink] [raw]
Subject: ACPI fixes


Len,

What about merging this patches in linux-acpi.bkbits.com ?

They seem to be in the ACPI tree for some time now.

ASUS A7V BIOS version 1011 from blacklist (Eric Valette)
support non ACPI compliant SCI over-ride specs (Jun Nakajima)
Fix ACPI oops on ThinkPad T32/T40 (Shaohua
Extended IRQ resource type for nForce (Andrew
Handle BIOS with _CRS that fails (Jun Nakajima)

Andrew, your fallback to PIC mode patch seems to be doing well, right?

Did you try to get it into the ACPI tree?




2003-09-15 22:39:16

by Andrew de Quincey

[permalink] [raw]
Subject: Re: ACPI fixes

On Monday 15 Sep 2003 10:33 pm, Marcelo Tosatti wrote:
> Len,
>
> What about merging this patches in linux-acpi.bkbits.com ?
>
> They seem to be in the ACPI tree for some time now.
>
> ASUS A7V BIOS version 1011 from blacklist (Eric Valette)
> support non ACPI compliant SCI over-ride specs (Jun Nakajima)
> Fix ACPI oops on ThinkPad T32/T40 (Shaohua
> Extended IRQ resource type for nForce (Andrew
> Handle BIOS with _CRS that fails (Jun Nakajima)
>
> Andrew, your fallback to PIC mode patch seems to be doing well, right?

I've not had any complaints, apart from that pci=noacpi bug (which is fixed).

> Did you try to get it into the ACPI tree?

I believe it should be in there already.. or if not, the core ACPI guys wanted
to test it a bit first because it made quite large changes to how IRQs were
setup.

2003-09-16 22:33:41

by Brown, Len

[permalink] [raw]
Subject: RE: ACPI fixes

Marcelo,
Yes, these are integrated, I'll update the version# and send you a pull
request later today.

Note the new URL:

http://linux-acpi.bkbits.net/linux-acpi-release-2.4.23

Is the tree dedicated for you to do pulls into 2.4.23

http://linux-acpi.bkbits.net/linux-acpi-test-2.4.23

Is the test tree where we'll stage things before dropping them into the
release tree. We'll cook Andrew's change here.

There are 2.4.22 versions of these trees also, for people who want the
latest ACPI backported into 2.4.22. (actually I don't back-port, I
integrate into the 2.4.22 tree and then pull forward into the 2.4.23
tree)

Thanks,
-Len

> -----Original Message-----
> From: Marcelo Tosatti [mailto:[email protected]]
> Sent: Monday, September 15, 2003 2:34 PM
> To: [email protected]
> Cc: Brown, Len; Andrew de Quincey
> Subject: ACPI fixes
>
>
>
> Len,
>
> What about merging this patches in linux-acpi.bkbits.com ?
>
> They seem to be in the ACPI tree for some time now.
>
> ASUS A7V BIOS version 1011 from blacklist (Eric Valette)
> support non ACPI compliant SCI over-ride specs (Jun Nakajima)
> Fix ACPI oops on ThinkPad T32/T40 (Shaohua
> Extended IRQ resource type for nForce (Andrew
> Handle BIOS with _CRS that fails (Jun Nakajima)
>
> Andrew, your fallback to PIC mode patch seems to be doing
> well, right?
>
> Did you try to get it into the ACPI tree?
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2003-09-17 06:50:53

by Brown, Len

[permalink] [raw]
Subject: [BKPATCH] ACPI 20030916 for 2.4.23-pre4

Hi Marcelo, please do a

bk pull http://linux-acpi.bkbits.net/linux-acpi-release-2.4.23

This will update the following files:

arch/i386/kernel/acpi.c | 1
arch/i386/kernel/dmi_scan.c | 9 +---
arch/i386/kernel/mpparse.c | 26 ++++++------
arch/i386/mm/ioremap.c | 2
drivers/acpi/ec.c | 7 ++-
drivers/acpi/events/evregion.c | 6 +-
drivers/acpi/pci_link.c | 61 ++++++++++++++++++++++++-----
include/acpi/acconfig.h | 2
8 files changed, 78 insertions(+), 36 deletions(-)

through these ChangeSets:

<[email protected]> (03/09/16 1.1063.43.6)
ACPI_CA_VERSION 0x20030916

<[email protected]> (03/09/12 1.1063.43.5)
fix off-by-one error in ioremap()
fixes kernel crash in acpi mode:
http://bugzilla.kernel.org/show_bug.cgi?id=1085

<[email protected]> (03/09/08 1.1063.43.4)
remove ASUS A7V BIOS version 1011 from blacklist (Eric Valette)

<[email protected]> (03/09/08 1.1063.43.3)
support non ACPI compliant SCI over-ride specs (Jun Nakajima)

<[email protected]> (03/09/08 1.1063.43.2)
Fix ACPI oops on ThinkPad T32/T40 (Shaohua David Li)

<[email protected]> (03/09/08 1.1063.43.1)
Extended IRQ resource type for nForce (Andrew de Quincey)
Handle BIOS with _CRS that fails (Jun Nakajima)





2003-09-17 06:50:58

by Brown, Len

[permalink] [raw]
Subject: Re: [BKPATCH] ACPI 20030916 for 2.4.23-pre4

ACPI 20030916 for 2.4.22 and 2.4.23-pre4 is available here:

http://linux-acpi.bkbits.net/linux-acpi-release-2.4.22
http://linux-acpi.bkbits.net/linux-acpi-release-2.4.23

The corresponding plain patches are available here:

http://sourceforge.net/project/showfiles.php?group_id=36832

The corresponding 2.6 update will be out shortly...

thanks,
-Len


On Tue, 2003-09-16 at 17:50, Len Brown wrote:
> Hi Marcelo, please do a
>
> bk pull http://linux-acpi.bkbits.net/linux-acpi-release-2.4.23
>
> This will update the following files:
>
> arch/i386/kernel/acpi.c | 1
> arch/i386/kernel/dmi_scan.c | 9 +---
> arch/i386/kernel/mpparse.c | 26 ++++++------
> arch/i386/mm/ioremap.c | 2
> drivers/acpi/ec.c | 7 ++-
> drivers/acpi/events/evregion.c | 6 +-
> drivers/acpi/pci_link.c | 61 ++++++++++++++++++++++++-----
> include/acpi/acconfig.h | 2
> 8 files changed, 78 insertions(+), 36 deletions(-)
>
> through these ChangeSets:
>
> <[email protected]> (03/09/16 1.1063.43.6)
> ACPI_CA_VERSION 0x20030916
>
> <[email protected]> (03/09/12 1.1063.43.5)
> fix off-by-one error in ioremap()
> fixes kernel crash in acpi mode:
> http://bugzilla.kernel.org/show_bug.cgi?id=1085
>
> <[email protected]> (03/09/08 1.1063.43.4)
> remove ASUS A7V BIOS version 1011 from blacklist (Eric Valette)
>
> <[email protected]> (03/09/08 1.1063.43.3)
> support non ACPI compliant SCI over-ride specs (Jun Nakajima)
>
> <[email protected]> (03/09/08 1.1063.43.2)
> Fix ACPI oops on ThinkPad T32/T40 (Shaohua David Li)
>
> <[email protected]> (03/09/08 1.1063.43.1)
> Extended IRQ resource type for nForce (Andrew de Quincey)
> Handle BIOS with _CRS that fails (Jun Nakajima)
>
>
>
>

2003-09-17 07:23:29

by Karol Kozimor

[permalink] [raw]
Subject: Re: [ACPI] Re: [BKPATCH] ACPI 20030916 for 2.4.23-pre4

Thus wrote Len Brown:
> ACPI 20030916 for 2.4.22 and 2.4.23-pre4 is available here:
>
> http://linux-acpi.bkbits.net/linux-acpi-release-2.4.22
> http://linux-acpi.bkbits.net/linux-acpi-release-2.4.23
>
> The corresponding plain patches are available here:
>
> http://sourceforge.net/project/showfiles.php?group_id=36832
>
> The corresponding 2.6 update will be out shortly...
[...]

Hi,
What about the ASUS ACPI driver updates?
Best regards,

--
Karol 'sziwan' Kozimor
[email protected]

2003-09-17 15:35:54

by Jesse Barnes

[permalink] [raw]
Subject: Re: [BKPATCH] ACPI 20030916 for 2.4.23-pre4

Can you please push this one as well? Thanks.

Jesse


diff -Nru a/drivers/acpi/tables.c b/drivers/acpi/tables.c
--- a/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
+++ b/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
@@ -69,7 +69,8 @@

static unsigned long sdt_pa; /* Physical Address */
static unsigned long sdt_count; /* Table count */
-static struct acpi_table_sdt *sdt_entry;
+
+static struct acpi_table_sdt sdt_entry[ACPI_MAX_TABLES];

void
acpi_table_print (
@@ -425,12 +426,6 @@
sdt_count = ACPI_MAX_TABLES;
}

- sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
- if (!sdt_entry) {
- printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
- return -ENOMEM;
- }
-
for (i = 0; i < sdt_count; i++)
sdt_entry[i].pa = (unsigned long) mapped_xsdt->entry[i];
}
@@ -475,12 +470,6 @@
printk(KERN_WARNING PREFIX "Truncated %lu RSDT entries\n",
(sdt_count - ACPI_MAX_TABLES));
sdt_count = ACPI_MAX_TABLES;
- }
-
- sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
- if (!sdt_entry) {
- printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
- return -ENOMEM;
}

for (i = 0; i < sdt_count; i++)

2003-09-17 16:48:36

by Brown, Len

[permalink] [raw]
Subject: Re: [BKPATCH] ACPI 20030916 for 2.4.23-pre4

Thanks Jesse,
yes, this and your pci_irq.c fix are in the queue and should pop out in
linux-acpi-test-2.*.* shortly; hopefully making linux-acpi-release-2.*.*
by the end of the week.

-Len

On Wed, 2003-09-17 at 11:35, Jesse Barnes wrote:
> Can you please push this one as well? Thanks.
>
> Jesse
>
>
> diff -Nru a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> --- a/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
> +++ b/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
> @@ -69,7 +69,8 @@
>
> static unsigned long sdt_pa; /* Physical Address */
> static unsigned long sdt_count; /* Table count */
> -static struct acpi_table_sdt *sdt_entry;
> +
> +static struct acpi_table_sdt sdt_entry[ACPI_MAX_TABLES];
>
> void
> acpi_table_print (
> @@ -425,12 +426,6 @@
> sdt_count = ACPI_MAX_TABLES;
> }
>
> - sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
> - if (!sdt_entry) {
> - printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
> - return -ENOMEM;
> - }
> -
> for (i = 0; i < sdt_count; i++)
> sdt_entry[i].pa = (unsigned long) mapped_xsdt->entry[i];
> }
> @@ -475,12 +470,6 @@
> printk(KERN_WARNING PREFIX "Truncated %lu RSDT entries\n",
> (sdt_count - ACPI_MAX_TABLES));
> sdt_count = ACPI_MAX_TABLES;
> - }
> -
> - sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
> - if (!sdt_entry) {
> - printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
> - return -ENOMEM;
> }
>
> for (i = 0; i < sdt_count; i++)

2003-09-19 03:49:11

by Brown, Len

[permalink] [raw]
Subject: Re: [BKPATCH] ACPI 20030916 for 2.4.23-pre4

Yes, and thanks!

This fix has been integrated with others in the ACPI patch,
and is available now in these bitkeeper trees:

http://linux-acpi.bkbits.net/linux-acpi-test-2.4.22
http://linux-acpi.bkbits.net/linux-acpi-test-2.4.23
http://linux-acpi.bkbits.net/linux-acpi-test-2.6.0


On Wed, 2003-09-17 at 11:35, Jesse Barnes wrote:
> Can you please push this one as well? Thanks.
>
> Jesse
>
>
> diff -Nru a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> --- a/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
> +++ b/drivers/acpi/tables.c Tue Sep 9 10:24:34 2003
> @@ -69,7 +69,8 @@
>
> static unsigned long sdt_pa; /* Physical Address */
> static unsigned long sdt_count; /* Table count */
> -static struct acpi_table_sdt *sdt_entry;
> +
> +static struct acpi_table_sdt sdt_entry[ACPI_MAX_TABLES];
>
> void
> acpi_table_print (
> @@ -425,12 +426,6 @@
> sdt_count = ACPI_MAX_TABLES;
> }
>
> - sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
> - if (!sdt_entry) {
> - printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
> - return -ENOMEM;
> - }
> -
> for (i = 0; i < sdt_count; i++)
> sdt_entry[i].pa = (unsigned long) mapped_xsdt->entry[i];
> }
> @@ -475,12 +470,6 @@
> printk(KERN_WARNING PREFIX "Truncated %lu RSDT entries\n",
> (sdt_count - ACPI_MAX_TABLES));
> sdt_count = ACPI_MAX_TABLES;
> - }
> -
> - sdt_entry = alloc_bootmem(sdt_count * sizeof(struct acpi_table_sdt));
> - if (!sdt_entry) {
> - printk(KERN_ERR "ACPI: Could not allocate mem for SDT entries!\n");
> - return -ENOMEM;
> }
>
> for (i = 0; i < sdt_count; i++)