2003-09-18 18:56:42

by Jens Kubieziel

[permalink] [raw]
Subject: [test5] make fails, warnings in swsusp.c

Hi,

I tried to compile 2.6.0-test5 today. But make fails:

,-----[ error message ]
| kernel/power/swsusp.c: In function `mark_swapfiles':
| kernel/power/swsusp.c:194: warning: implicit declaration of function `rw_swap_page_sync'
| kernel/power/swsusp.c: In function `read_swapfiles':
| kernel/power/swsusp.c:223: warning: implicit declaration of function `swap_list_lock'
| kernel/power/swsusp.c:225: error: `swap_info' undeclared (first use in this function)
| kernel/power/swsusp.c:225: error: (Each undeclared identifier is reported only once
| kernel/power/swsusp.c:225: error: for each function it appears in.)
| kernel/power/swsusp.c:250: warning: implicit declaration of function `swap_list_unlock'
| kernel/power/swsusp.c: In function `lock_swapdevices':
| kernel/power/swsusp.c:261: error: `swap_info' undeclared (first use in this function)
| make[2]: *** [kernel/power/swsusp.o] Error 1
| make[1]: *** [kernel/power] Error 2
| make: *** [kernel] Error 2
`--------------

This happened on an AMD Athlon 1GHz with:

,-----[ lspci ]
| 00:00.0 Host bridge: VIA Technologies, Inc. VT8366/A/7 [Apollo KT266/A/333]
| 00:01.0 PCI bridge: VIA Technologies, Inc. VT8366/A/7 [Apollo KT266/A/333 AGP]
| 00:09.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10)
| 00:11.0 ISA bridge: VIA Technologies, Inc. VT8233 PCI to ISA Bridge
| 00:11.1 IDE interface: VIA Technologies, Inc. VT82C586/B/686A/B PIPC Bus Master IDE (rev 06)
| 00:11.2 USB Controller: VIA Technologies, Inc. USB (rev 1b)
| 00:11.3 USB Controller: VIA Technologies, Inc. USB (rev 1b)
| 00:11.4 USB Controller: VIA Technologies, Inc. USB (rev 1b)
| 00:11.5 Multimedia audio controller: VIA Technologies, Inc. VT8233 AC97 Audio Controller (rev 30)
| 01:00.0 VGA compatible controller: nVidia Corporation NV17 [GeForce4 MX 440] (rev a3)
|
`--------------

My .config is attached. Furthermore there was a typo in swsusp.c. Patch
is also attached.
--
Jens Kubieziel http://www.kubieziel.de
hard, adj.:
The quality of your own data; also how it is to believe those
of other people.


Attachments:
(No filename) (2.07 kB)
.config (21.51 kB)
swsusp.c.diff (377.00 B)
Download all attachments

2003-09-18 19:30:06

by Milton Miller

[permalink] [raw]
Subject: Re: [test5] make fails, warnings in swsusp.c

See http://www.ussg.iu.edu/hypermail/linux/kernel/0309.1/1759.html

I never heard back why this is not the right fix, despite initial
objections. However, I leave it to others to push ...

milton