2003-11-12 22:05:12

by Dan Christian

[permalink] [raw]
Subject: [PATCH] 16654 UART drops transmit characters

A 16654 UART (with 64 byte FIFO and hardware flow control) can drop
characters on TRANSMIT if hardware flow control is used.

No UART should ever lose data on transmit, so I consider this a major
bug. The bug only shows up if you write chunks of data >64 bytes.

Enclosed is a patch that fixes the problem. I have tested it under
2.4.20. It also applies cleanly under 2.4.22.

This has been reported before, but apparently the patch never made it
into the Linux kernel. Ed Vance (edv) at MacroLink developed this fix.
Part of it fixed some bad code for supporting the buggy Elan
interrupts. That part got fixed and is not in the attached patch.
Other than that, I just updated Ed's patch to apply cleanly against
current kernels.

-Dan Christian


Attachments:
(No filename) (763.00 B)
patch_elan4 (1.37 kB)
Download all attachments