2003-11-24 06:57:32

by Geoffrey Lee

[permalink] [raw]
Subject: [patch] sis comparison / assignment operator fix

Hi,


This fixes what seems to be an obvious = vs == bug in the init301.c
sis file.

It has

if (temp = 0xffff) return;

which should always be true, so it always returns.

- g.
--
geoff.


Attachments:
(No filename) (191.00 B)
sis-init301.c.patch (480.00 B)
Download all attachments

2003-11-24 09:07:16

by Thomas Winischhofer

[permalink] [raw]
Subject: Re: [patch] sis comparison / assignment operator fix


Geoffrey Lee wrote:
> This fixes what seems to be an obvious = vs == bug in the init301.c
> sis file.
>
> It has
>
> if (temp = 0xffff) return;
>
> which should always be true, so it always returns.

You did notice the "#if 0" - "#endif" around that code, didn't you?

BTW: Patching a more than 10 months old version of that driver is
pointless anyway. The current fb-related development is exclusively done
in James Simmon's fbdev tree, and current versions of the sisfb driver
are obtainable at http://www.winischhofer.net/linuxsisvga.shtml

Thomas

--
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net *** http://www.winischhofer.net/
twini AT xfree86 DOT org