2003-11-28 02:26:46

by Peter Lieverdink

Subject: include/linux/skbuff.h Typo

Compiling 2.6.0-test11 (PPC) errors out on line 844 of skbuff.h. I'm
guessing the following patch makes it do what it should.

- Peter.


--- linux-2.6.0-test11/include/linux/skbuff_orig.h 2003-11-28
13:22:47.892405000 +1100
+++ linux-2.6.0-test11/include/linux/skbuff.h 2003-11-28
13:20:02.142405000 +1100
@@ -841,7 +841,7 @@
SKB_LINEAR_ASSERT(skb);
skb->tail += len;
skb->len += len;
- if (unlikely(skb=>tail>skb->end))
+ if (unlikely(skb->tail > skb->end))
skb_over_panic(skb, len, current_text_addr());
return tmp;
}

2003-11-28 02:43:11

by Arnaldo Carvalho de Melo

Subject: Re: include/linux/skbuff.h Typo

Em Fri, Nov 28, 2003 at 01:26:17PM +1100, Peter Lieverdink escreveu:
> Compiling 2.6.0-test11 (PPC) errors out on line 844 of skbuff.h. I'm
> guessing the following patch makes it do what it should.
>
> - Peter.
>
>
> --- linux-2.6.0-test11/include/linux/skbuff_orig.h 2003-11-28
> 13:22:47.892405000 +1100
> +++ linux-2.6.0-test11/include/linux/skbuff.h 2003-11-28
> 13:20:02.142405000 +1100
> @@ -841,7 +841,7 @@
> SKB_LINEAR_ASSERT(skb);
> skb->tail += len;
> skb->len += len;
> - if (unlikely(skb=>tail>skb->end))
> + if (unlikely(skb->tail > skb->end))
> skb_over_panic(skb, len, current_text_addr());
> return tmp;

Sure thing, but what tree is this one you are using? I checked 2.6.0-test11
and there is no => thinko there...

- Arnaldo