2004-01-04 09:08:08

by OGAWA Hirofumi

[permalink] [raw]
Subject: Re: [PATCH] FAT: Support the large partition (> 128GB) for 2.4

Erik Andersen <[email protected]> writes:

> > This is used for updates (not create) of the directory entry, and
> > overflowed by large partition (> 128GB).
>
> I think this additional fat32 patch would be a good idea for
> 2.4.x. Could you review these changes and perhaps fold them into
> your patch for inclusion into 2.4.x. This patch fixes support
> for the full 4GB (-1 bytes) allowable fat32 file size, and should
> be added onto of your previous patch for large fat32 filesystems.

Basically looks good. But it was forgetting to fix the mmu_private of
some filesystems.

If previous patch was applied and someone didn't submit this stuff,
I'll try it.

Thanks.
--
OGAWA Hirofumi <[email protected]>


2004-01-04 09:25:56

by Erik Andersen

[permalink] [raw]
Subject: Re: [PATCH] FAT: Support the large partition (> 128GB) for 2.4

On Sun Jan 04, 2004 at 06:07:35PM +0900, OGAWA Hirofumi wrote:
> Erik Andersen <[email protected]> writes:
>
> > > This is used for updates (not create) of the directory entry, and
> > > overflowed by large partition (> 128GB).
> >
> > I think this additional fat32 patch would be a good idea for
> > 2.4.x. Could you review these changes and perhaps fold them into
> > your patch for inclusion into 2.4.x. This patch fixes support
> > for the full 4GB (-1 bytes) allowable fat32 file size, and should
> > be added onto of your previous patch for large fat32 filesystems.
>
> Basically looks good. But it was forgetting to fix the mmu_private of
> some filesystems.

Yes, I suppose all filesystems should be fixed.

> If previous patch was applied and someone didn't submit this stuff,
> I'll try it.

That would be great.

-Erik

--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--