2004-01-05 22:18:32

by Adrian Bunk

[permalink] [raw]
Subject: Re: kernel 2.6.0, wrong Kconfig directives

On Tue, Dec 23, 2003 at 12:56:23AM +0100, Andrea Barisani wrote:
>
> Hi folks,

Hi Andrea,

> Installing 2.6.0 I've found that some kernel options directives are wrong,
> in fact the option turns out to be always enabled. I don't think this is
> a desired behaviour.
>
> Sorry for the format, yes I know it's ugly :) but I'll leave to you the proper
> solution :) so I can't make a proper patch.
>
>
> - IPV6_SCTP___ option is always turned on
>
> ./net/sctp/Kconfig:
>
> 8: config IPV6_SCTP__
> 9: tristate
> 10: default y if IPV6=n
> 11: default IPV6 if IPV6
> 12:
> 13: config IP_SCTP
> 14: tristate "The SCTP Protocol (EXPERIMENTAL)"
> 15: depends on IPV6_SCTP__
>
>
> I think something is wrong here, why the 'default y if IPV6=n' ???


It's ___ugly___ but designed this way...

The whole purpose of IPV6_SCTP__ is to disallow static IP_SCTP with
modular IPV6.


> - INPUT_MOUSEDEV option is always turned on
>
> ./drivers/input/Kconfig:
>
> 27: config INPUT_MOUSEDEV
> 28: tristate "Mouse interface" if EMBEDDED
> 29: default y
> 30: depends on INPUT
>
> 43: config INPUT_MOUSEDEV_PSAUX
> 44: bool "Provide legacy /dev/psaux device" if EMBEDDED
> 45: default y
> 46: depends on INPUT_MOUSEDEV
>
>
> the tristate directive is ignored in most default configurations since EMBEDDED
> is not set, however this doesn't allow to disable INPUT_MOUSEDEV and
> INPUT_MOUSEDEV_PSAUX. I don't suppose this is right.
>...

These EMBEDDED are there to help people not to accidentially disable
these options although they might require them.

> Bye
>...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2004-01-05 23:04:22

by Andrea Barisani

[permalink] [raw]
Subject: Re: kernel 2.6.0, wrong Kconfig directives

On Mon, Jan 05, 2004 at 11:17:32PM +0100, Adrian Bunk wrote:
> On Tue, Dec 23, 2003 at 12:56:23AM +0100, Andrea Barisani wrote:
> >
> > Hi folks,
>
> Hi Andrea,

Hi!

>
> > Installing 2.6.0 I've found that some kernel options directives are wrong,
> > in fact the option turns out to be always enabled. I don't think this is
> > a desired behaviour.
> >
> > Sorry for the format, yes I know it's ugly :) but I'll leave to you the proper
> > solution :) so I can't make a proper patch.
> >
> >
> > - IPV6_SCTP___ option is always turned on
> >
> > ./net/sctp/Kconfig:
> >
> > 8: config IPV6_SCTP__
> > 9: tristate
> > 10: default y if IPV6=n
> > 11: default IPV6 if IPV6
> > 12:
> > 13: config IP_SCTP
> > 14: tristate "The SCTP Protocol (EXPERIMENTAL)"
> > 15: depends on IPV6_SCTP__
> >
> >
> > I think something is wrong here, why the 'default y if IPV6=n' ???
>
>
> It's ___ugly___ but designed this way...
>
> The whole purpose of IPV6_SCTP__ is to disallow static IP_SCTP with
> modular IPV6.

Ok, so it's actually a "dummy" config with not linked with real code. A
simple grep suggest that. If so I won't complain again, now it's clear ;)

However it's really ___ugly___ ;)

>
> These EMBEDDED are there to help people not to accidentially disable
> these options although they might require them.

Ok that's fine, however I personally think this should be documented in
EMBEDDED related options to let people know how they can disable them.

And I really think that MOUSEDEV should not be considered a 'not-standard'
option. It's quite common disabling MOUSE support on servers, terminals and
so on. :)

> cu
> Adrian

Bye and thanks

--
------------------------------------------------------------
INFIS Network Administrator & Security Officer .*.
Department of Physics - University of Trieste V
[email protected] - GPG Key 0x864C9B9E ( )
---------------------------------------------------- ( )
"How would you know I'm mad?" said Alice. ^^-^^
"You must be,'said the Cat,'or you wouldn't have come here."
------------------------------------------------------------

2004-01-06 01:22:29

by Adrian Bunk

[permalink] [raw]
Subject: Re: kernel 2.6.0, wrong Kconfig directives

On Mon, Jan 05, 2004 at 11:59:54PM +0100, Andrea Barisani wrote:
> Hi!

Hi Andrea!

>...
> And I really think that MOUSEDEV should not be considered a 'not-standard'
> option. It's quite common disabling MOUSE support on servers, terminals and
> so on. :)

If the only effect of an unnecessaryly enabled option are a few kB
wasted space, this isn't a big problem in most situations.

If it's easy to accidentially disable an important option, it's good to
protect users against doing so.

People who _really_ need the space simply enable EMBEDDED to disable
such an option.

> Bye and thanks

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed