Once more...
The patch was made against 2.6.0-test11, but I checked 2.6.1-rc1-bk and
2.6.1-rc1-mm2 - they're still not fixed.
Or should I just click-click this into bugzilla and wait?
----- Forwarded message from Jakub Bogusz <[email protected]> -----
Date: Sat, 6 Dec 2003 02:06:21 +0100
From: Jakub Bogusz
To: [email protected]
Subject: [PATCH] 2.6.0-test* - oopses in some OSS drivers
Hello,
some time ago I reported Oops which I got on "rmmod es1371"
(http://www.ussg.iu.edu/hypermail/linux/kernel/0310.2/0656.html).
It was caused by __devinit used for *_remove() function (it affects
configurations with CONFIG_MODULES=y and CONFIG_HOTPLUG not set).
I found the same issue in more OSS drivers sources - and it's still
present in -test11.
Here is patch for this issue - details inside.
Tested on es1371 module - rmmod doesn't cause Oops any longer.
--
Jakub Bogusz http://cyber.cs.net.pl/~qboosh/
PLD Linux http://www.pld-linux.org/
Jakub Bogusz <[email protected]> wrote:
>
> The patch was made against 2.6.0-test11, but I checked 2.6.1-rc1-bk and
> 2.6.1-rc1-mm2 - they're still not fixed.
Patch seem fine, thanks.
> Or should I just click-click this into bugzilla and wait?
bugzilla is a bit of a black hole, sorry. Sending (and resending) to the
mailing list is appropriate.
Andrew Morton wrote:
> Jakub Bogusz <[email protected]> wrote:
> >
> > The patch was made against 2.6.0-test11, but I checked 2.6.1-rc1-bk and
> > 2.6.1-rc1-mm2 - they're still not fixed.
>
> Patch seem fine, thanks.
>
> > Or should I just click-click this into bugzilla and wait?
>
> bugzilla is a bit of a black hole, sorry. Sending (and resending) to the
> mailing list is appropriate.
Hmm, in that case, can we add to that patch the use-after-free
oops fix for the MultiSound OSS driver too? Its a one-liner:
just remove __init from the msnd_register() declaration on line 60 of
sound/oss/msnd.c
its #1709 in bugzilla
--
Jamie Heilman http://audible.transient.net/~jamie/
"You came all this way, without saying squat, and now you're trying
to tell me a '56 Chevy can beat a '47 Buick in a dead quarter mile?
I liked you better when you weren't saying squat kid." -Buddy