Hi,
trivial fix ...
Gerd
==============================[ cut here ]==============================
--- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
+++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
@@ -429,6 +429,8 @@
source "drivers/char/Kconfig"
+source "drivers/i2c/Kconfig"
+
source "drivers/misc/Kconfig"
source "drivers/media/Kconfig"
Gerd Knorr <[email protected]> wrote:
>
> Hi,
>
> trivial fix ...
>
> Gerd
>
> ==============================[ cut here ]==============================
> --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> @@ -429,6 +429,8 @@
>
> source "drivers/char/Kconfig"
>
> +source "drivers/i2c/Kconfig"
> +
> source "drivers/misc/Kconfig"
>
Ah-hah! That's why the ppc64 kbuild system is whining about undefined but
used i2c symbols:
drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols
drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
So this change needs to be propagated to other architectures as well.
Gerd Knorr <[email protected]> writes:
>
> ==============================[ cut here ]==============================
> --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> @@ -429,6 +429,8 @@
>
> source "drivers/char/Kconfig"
>
> +source "drivers/i2c/Kconfig"
> +
There is no such source in arch/i386/Kconfig. So it's probably wrong.
-Andi
On Tue, Jan 20, 2004 at 09:10:35AM -0800, Andrew Morton wrote:
> > Hi,
> >
> > trivial fix ...
> >
> > Gerd
> >
> > ==============================[ cut here ]==============================
> > --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > @@ -429,6 +429,8 @@
> >
> > source "drivers/char/Kconfig"
> >
> > +source "drivers/i2c/Kconfig"
> > +
> > source "drivers/misc/Kconfig"
> >
>
> Ah-hah! That's why the ppc64 kbuild system is whining about undefined but
> used i2c symbols:
>
> drivers/ieee1394/Kconfig:60:warning: enable is only allowed with boolean and tristate symbols
> drivers/media/video/Kconfig:13:warning: enable is only allowed with boolean and tristate symbols
>
> So this change needs to be propagated to other architectures as well.
The better approach is to use the generic drivers/Kconfig,
as used by i386, parisc and cris today.
Sam
Andi Kleen <[email protected]> wrote:
>
> Gerd Knorr <[email protected]> writes:
> >
> > ==============================[ cut here ]==============================
> > --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > @@ -429,6 +429,8 @@
> >
> > source "drivers/char/Kconfig"
> >
> > +source "drivers/i2c/Kconfig"
> > +
>
> There is no such source in arch/i386/Kconfig. So it's probably wrong.
>
arch/i386/Kconfig sources drivers/Kconfig, which then picks up the i2c stuff.
Gerd Knorr <[email protected]> wrote:
>
> Hi,
>
> trivial fix ...
>
> Gerd
>
> ==============================[ cut here ]==============================
> --- linux-mm5-2.6.1/arch/x86_64/Kconfig.i2c 2004-01-20 13:14:42.000000000 +0100
> +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> @@ -429,6 +429,8 @@
>
> source "drivers/char/Kconfig"
>
> +source "drivers/i2c/Kconfig"
> +
> source "drivers/misc/Kconfig"
>
> source "drivers/media/Kconfig"
Apparently architectures should be sourcing the generic drivers/Kconfig
file. But let's run with your fix for now.
On Tue, 20 Jan 2004 19:32:59 +0100
Gerd Knorr <[email protected]> wrote:
> On Tue, Jan 20, 2004 at 01:59:46PM +0100, Andi Kleen wrote:
> > Gerd Knorr <[email protected]> writes:
> > >
> > > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > > +source "drivers/i2c/Kconfig"
> > > +
> >
> > There is no such source in arch/i386/Kconfig. So it's probably wrong.
>
> i386 includes that indirectly via drivers/Kconfig
> So should the other archs do that too?
Yep. Or at least x86-64 should likely.
But it must have worked until recently because I got a report about I2C on x86-64 for 2.6.0.
-Andi
On Tue, Jan 20, 2004 at 01:59:46PM +0100, Andi Kleen wrote:
> Gerd Knorr <[email protected]> writes:
> >
> > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > +source "drivers/i2c/Kconfig"
> > +
>
> There is no such source in arch/i386/Kconfig. So it's probably wrong.
i386 includes that indirectly via drivers/Kconfig
So should the other archs do that too?
Gerd
--
"... und auch das ganze Wochenende oll" -- Wetterbericht auf RadioEins
On Tue, Jan 20, 2004 at 07:51:32PM +0100, Andi Kleen wrote:
> On Tue, 20 Jan 2004 19:32:59 +0100
> Gerd Knorr <[email protected]> wrote:
>
> > On Tue, Jan 20, 2004 at 01:59:46PM +0100, Andi Kleen wrote:
> > > Gerd Knorr <[email protected]> writes:
> > > >
> > > > +++ linux-mm5-2.6.1/arch/x86_64/Kconfig 2004-01-20 13:15:10.000000000 +0100
> > > > +source "drivers/i2c/Kconfig"
> > > > +
> > >
> > > There is no such source in arch/i386/Kconfig. So it's probably wrong.
> >
> > i386 includes that indirectly via drivers/Kconfig
> > So should the other archs do that too?
>
> Yep. Or at least x86-64 should likely.
>
> But it must have worked until recently because I got a report about I2C on x86-64 for 2.6.0.
Yes, I just moved the i2c Kconfig out of the char menu, and into the
main drivers/Kconfig.
And here I thought all of the archs had switched to using that file,
instead of trying to put together their own drivers menus :)
thanks,
greg k-h