2004-01-23 06:36:42

by Dave Jones

Subject: Suspicious pointer usage in kobil_sct driver.

Greg, is this what's intended here?

Dave

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
--- bk-linus/drivers/usb/serial/kobil_sct.c 2003-09-29 20:00:01.000000000 +0100
+++ linux-2.5/drivers/usb/serial/kobil_sct.c 2004-01-23 05:06:40.000000000 +0000
@@ -651,7 +651,7 @@ static int kobil_ioctl(struct usb_seria
return 0;

case TCSETS: // 0x5402
- if (! &port->tty->termios) {
+ if (!(port->tty->termios)) {
dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
return -ENOTTY;
}

2004-01-23 21:01:05

by Greg KH

Subject: Re: Suspicious pointer usage in kobil_sct driver.

On Fri, Jan 23, 2004 at 06:35:25AM +0000, [email protected] wrote:
> Greg, is this what's intended here?

Yes, your patch is correct. I'll go apply it, thanks.

greg k-h

> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
> --- bk-linus/drivers/usb/serial/kobil_sct.c 2003-09-29 20:00:01.000000000 +0100
> +++ linux-2.5/drivers/usb/serial/kobil_sct.c 2004-01-23 05:06:40.000000000 +0000
> @@ -651,7 +651,7 @@ static int kobil_ioctl(struct usb_seria
> return 0;
>
> case TCSETS: // 0x5402
> - if (! &port->tty->termios) {
> + if (!(port->tty->termios)) {
> dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
> return -ENOTTY;
> }

2004-01-27 00:44:40

by Greg KH

Subject: Re: Suspicious pointer usage in kobil_sct driver.

On Fri, Jan 23, 2004 at 06:35:25AM +0000, [email protected] wrote:
> Greg, is this what's intended here?

Applied, thanks.

greg k-h