2004-01-26 01:45:30

by Philippe Elie

[permalink] [raw]
Subject: [PATCH] oprofile, typo in alpha driver

Unless I miss something this look like a typo, one user reported to get error
from the daemon: 'Unknown event for counter 1' (alpha ev6) and the behavior
was better but not completly sane after trying this patch: he get spurious
event for counter 1 when enabling only counter 0 but rarely now. No alpha box
to test this.

regards,
Phil

Index: arch/alpha/oprofile/common.c
===================================================================
RCS file: /usr/local/cvsroot/linux-2.5/arch/alpha/oprofile/common.c,v
retrieving revision 1.5
diff -u -p -r1.5 common.c
--- arch/alpha/oprofile/common.c 21 Jun 2003 16:20:31 -0000 1.5
+++ arch/alpha/oprofile/common.c 26 Jan 2004 02:43:38 -0000
@@ -57,7 +57,7 @@ op_axp_setup(void)

/* Compute the mask of enabled counters. */
for (i = e = 0; i < model->num_counters; ++i)
- if (ctr[0].enabled)
+ if (ctr[i].enabled)
e |= 1 << i;
reg.enable = e;