2004-01-26 11:31:10

by Patrick Caulfield

[permalink] [raw]
Subject: [PATCH] 1/2 DECnet fix SDF_WILD

This patch fixes the operation of SDF_WILD sockets on Linux 2.6.0/1
(they don't currently work at all).

--- net/decnet/af_decnet.c.orig 2003-12-08 11:27:59.000000000 +0000
+++ net/decnet/af_decnet.c 2003-12-08 11:28:34.000000000 +0000
@@ -163,7 +163,7 @@
struct dn_scp *scp = DN_SK(sk);

if (scp->addr.sdn_flags & SDF_WILD)
- return hlist_empty(&dn_wild_sk) ? NULL : &dn_wild_sk;
+ return hlist_empty(&dn_wild_sk) ? &dn_wild_sk : NULL;

return &dn_sk_hash[scp->addrloc & DN_SK_HASH_MASK];
}


patrick


2004-01-30 20:43:55

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] 1/2 DECnet fix SDF_WILD

On Mon, 26 Jan 2004 11:31:06 +0000
Patrick Caulfield <[email protected]> wrote:

> This patch fixes the operation of SDF_WILD sockets on Linux 2.6.0/1
> (they don't currently work at all).

Please resubmit your patches as attachments or somehow otherwise
teach your email client not to turn tabs into spaces as this corrupts
your patches.

Thanks.

2004-01-31 11:41:07

by Patrick Caulfield

[permalink] [raw]
Subject: Re: [PATCH] 1/2 DECnet fix SDF_WILD

On Fri, Jan 30, 2004 at 12:43:48PM -0800, David S. Miller wrote:
> On Mon, 26 Jan 2004 11:31:06 +0000
> Patrick Caulfield <[email protected]> wrote:
>
> > This patch fixes the operation of SDF_WILD sockets on Linux 2.6.0/1
> > (they don't currently work at all).
>
> Please resubmit your patches as attachments or somehow otherwise
> teach your email client not to turn tabs into spaces as this corrupts
> your patches.

Sorry about that. Here are both patches attached (and in -p1 format this time
too)

patrick


Attachments:
(No filename) (522.00 B)
decnet-patch1 (505.00 B)
decnet-patch2 (447.00 B)
Download all attachments

2004-02-01 01:49:54

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] 1/2 DECnet fix SDF_WILD

On Sat, 31 Jan 2004 11:41:01 +0000
Patrick Caulfield <[email protected]> wrote:

> Sorry about that. Here are both patches attached (and in -p1 format this time
> too)

Applied, thanks Patrick.