2004-03-01 06:27:25

by Rusty Russell

[permalink] [raw]
Subject: Re: [PATCH] Add a MODULE_VERSION macro

In message <[email protected]> you write:
> > ifneq ($(filter-out $(modules),$(__modules)),)
> > + $(warning Trouble: $(__modules) )
> > $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> > $(warning do not complain if something goes wrong.)
> > endif
>
> Hi Rusty,
> what is this line supposed to do, except making it impossible
> to build kernel modules in temporary directories? Now when I build
> out-of-tree modules, I get 'Trouble:' followed by approximate 16000
> characters listing paths to all modules I have in kernel

Patch below: does it help?

Rusty
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
--- linux-2.6.4-rc1-bk1/scripts/Makefile.modpost 2004-02-29 19:11:38.000000000 +1100
+++ tmp/scripts/Makefile.modpost 2004-03-01 16:40:33.000000000 +1100
@@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))

ifneq ($(filter-out $(modules),$(__modules)),)
- $(warning Trouble: $(__modules) )
+ $(warning Trouble: $(filter-out $(modules),$(__modules)))
$(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
$(warning do not complain if something goes wrong.)
endif


2004-03-01 12:02:58

by Petr Vandrovec

[permalink] [raw]
Subject: Re: [PATCH] Add a MODULE_VERSION macro

On Mon, Mar 01, 2004 at 04:41:24PM +1100, Rusty Russell wrote:
> Patch below: does it help?

Yes, much better:

/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:17: Trouble: /tmp/vmware-config1/vmnet-only/vmnet.ko
/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:18: *** Uh-oh, you have stale module entries. You messed with SUBDIRS,/usr/src/linus/linux-2.6.3-c1663/scripts/Makefile.modpost:19: do not complain if something goes wrong.

Thanks,
Petr Vandrovec

>
> Rusty
> --
> Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
>
> diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal linux-2.6.4-rc1-bk1/scripts/Makefile.modpost tmp/scripts/Makefile.modpost
> --- linux-2.6.4-rc1-bk1/scripts/Makefile.modpost 2004-02-29 19:11:38.000000000 +1100
> +++ tmp/scripts/Makefile.modpost 2004-03-01 16:40:33.000000000 +1100
> @@ -14,7 +14,7 @@ __modules := $(shell head -q -n1 /dev/nu
> modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o)))
>
> ifneq ($(filter-out $(modules),$(__modules)),)
> - $(warning Trouble: $(__modules) )
> + $(warning Trouble: $(filter-out $(modules),$(__modules)))
> $(warning *** Uh-oh, you have stale module entries. You messed with SUBDIRS,)
> $(warning do not complain if something goes wrong.)
> endif
>