2004-03-01 22:50:18

by Frank Cusack

Subject: [PATCH] vicam ioctl VIDIOCSWIN wrong return value

Should this return -EINVAL? (credit to Paul Menage).

diff -urp linux-2.4.25/drivers/usb/vicam.c linux-2.4.25.1/drivers/usb/vicam.c
--- linux-2.4.25/drivers/usb/vicam.c 2004-02-18 05:36:31.000000000 -0800
+++ linux-2.4.25.1/drivers/usb/vicam.c 2004-03-01 14:47:59.000000000 -0800
@@ -612,7 +612,7 @@ vicam_ioctl(struct video_device *dev, un
DBG("VIDIOCSWIN %d x %d\n", vw->width, vw->height);

if ( vw.width != 320 || vw.height != 240 )
- retval = -EFAULT;
+ retval = -EINVAL;

break;
}

/fc