2004-03-03 21:57:55

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] DVB stv0299.c: remove unused variable

The stv0299 DVB frontend update in Linus' 2.6 tree introduced a
completely unused variable:

<-- snip -->

...
CC drivers/media/dvb/frontends/stv0299.o
drivers/media/dvb/frontends/stv0299.c: In function `tsa5059_set_tv_freq':
drivers/media/dvb/frontends/stv0299.c:356: warning: unused variable `i'
...

<-- snip -->


The following patch removes this variable:


--- linux-2.6.4-rc1-mm2/drivers/media/dvb/frontends/stv0299.c.old 2004-03-03 22:51:19.000000000 +0100
+++ linux-2.6.4-rc1-mm2/drivers/media/dvb/frontends/stv0299.c 2004-03-03 22:52:57.000000000 +0100
@@ -353,7 +353,7 @@
u8 addr;
u32 div;
u8 buf[4];
- int i, divisor, regcode;
+ int divisor, regcode;

dprintk ("%s: freq %i, ftype %i\n", __FUNCTION__, freq, ftype);



Please apply
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2004-03-04 08:49:15

by Michael Hunold

[permalink] [raw]
Subject: Re: [2.6 patch] DVB stv0299.c: remove unused variable

Hello Adrian,

On 03/03/04 22:55, Adrian Bunk wrote:
> The stv0299 DVB frontend update in Linus' 2.6 tree introduced a
> completely unused variable:
>
> <-- snip -->
>
> ...
> CC drivers/media/dvb/frontends/stv0299.o
> drivers/media/dvb/frontends/stv0299.c: In function `tsa5059_set_tv_freq':
> drivers/media/dvb/frontends/stv0299.c:356: warning: unused variable `i'
> ...
>
> <-- snip -->
>
>
> The following patch removes this variable:
>
>
> --- linux-2.6.4-rc1-mm2/drivers/media/dvb/frontends/stv0299.c.old 2004-03-03 22:51:19.000000000 +0100
> +++ linux-2.6.4-rc1-mm2/drivers/media/dvb/frontends/stv0299.c 2004-03-03 22:52:57.000000000 +0100

Thanks. The patch is already in our local CVS and will be in the next
DVB update.

Please CC the official "maintainer" address
<[email protected]> the next time. Thanks!

CU
Michael.