2004-03-07 15:52:32

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.6 patch] MAINTAINERS: remove LAN media entry

On Sat, Feb 28, 2004 at 11:57:11AM +0100, Daniel Egger wrote:
> On Feb 27, 2004, at 9:54 pm, Adrian Bunk wrote:
>
> >IOW:
> >The entry from MAINTAINER can be removed?
>
> This one for sure. The same is probably sensible for the
> drivers, too. It's just too confusing to not several
> versions of the driver floating around which need different
> tools. And since the manufacturer propagates their own
> version, the linux one should go...
>...


It's a question whether removing drivers from a stable kernel series is
a good idea, but the following is definitely correct:


--- linux-2.6.4-rc1-mm2/MAINTAINERS.old 2004-03-07 16:47:18.000000000 +0100
+++ linux-2.6.4-rc1-mm2/MAINTAINERS 2004-03-07 16:47:32.000000000 +0100
@@ -1200,12 +1200,6 @@
W: http://www.cse.unsw.edu.au/~neilb/patches/linux-devel/
S: Maintained

-LANMEDIA WAN CARD DRIVER
-P: Andrew Stanley-Jones
-M: [email protected]
-W: http://www.lanmedia.com/
-S: Supported
-
LAPB module
P: Henner Eisen
M: [email protected]



> Servus,
> Daniel

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2004-03-07 16:25:39

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [2.6 patch] MAINTAINERS: remove LAN media entry

On Sun, Mar 07, 2004 at 04:51:47PM +0100, Adrian Bunk wrote:
> On Sat, Feb 28, 2004 at 11:57:11AM +0100, Daniel Egger wrote:
> > On Feb 27, 2004, at 9:54 pm, Adrian Bunk wrote:
> >
> > >IOW:
> > >The entry from MAINTAINER can be removed?
> >
> > This one for sure. The same is probably sensible for the
> > drivers, too. It's just too confusing to not several
> > versions of the driver floating around which need different
> > tools. And since the manufacturer propagates their own
> > version, the linux one should go...
> >...
>
>
> It's a question whether removing drivers from a stable kernel series is
> a good idea, but the following is definitely correct:

Why do you remove it completely, instead of just marking it unmaintained,
and remove the address information?
They when searching you know the you have found the right entry, but
unfortunately it is unmaintained.

Sam

2004-03-07 16:32:56

by Adrian Bunk

[permalink] [raw]
Subject: Re: [2.6 patch] MAINTAINERS: remove LAN media entry

On Sun, Mar 07, 2004 at 05:25:23PM +0100, Sam Ravnborg wrote:
> On Sun, Mar 07, 2004 at 04:51:47PM +0100, Adrian Bunk wrote:
> > On Sat, Feb 28, 2004 at 11:57:11AM +0100, Daniel Egger wrote:
> > > On Feb 27, 2004, at 9:54 pm, Adrian Bunk wrote:
> > >
> > > >IOW:
> > > >The entry from MAINTAINER can be removed?
> > >
> > > This one for sure. The same is probably sensible for the
> > > drivers, too. It's just too confusing to not several
> > > versions of the driver floating around which need different
> > > tools. And since the manufacturer propagates their own
> > > version, the linux one should go...
> > >...
> >
> >
> > It's a question whether removing drivers from a stable kernel series is
> > a good idea, but the following is definitely correct:
>
> Why do you remove it completely, instead of just marking it unmaintained,
> and remove the address information?
> They when searching you know the you have found the right entry, but
> unfortunately it is unmaintained.

In 2.6.4-rc1-mm2, there's exactly one entry marked "Unmaintained"
(PCMCIA SUBSYSTEM) and there are very few marked "Orphan".

I don't have a strong opinion on this, but my impresion was that usually
unmaintained device drivers are not listed in MAINTAINERS.

> Sam

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

2004-03-07 16:53:35

by Daniel Egger

[permalink] [raw]
Subject: Re: [2.6 patch] MAINTAINERS: remove LAN media entry

On Mar 7, 2004, at 4:51 pm, Adrian Bunk wrote:

> It's a question whether removing drivers from a stable kernel series is
> a good idea, but the following is definitely correct:

It would be nevertheless nice though if someone would actually confirm
that the drivers work at all. And even more it would be really cool to
know where to find the tools to control the modus operandi and whether
they work at all.

I have one of those cards is a pretty obscure machine but lacking a
T-1/E-1 connection I cannot test it over here.

Servus,
Daniel


Attachments:
PGP.sig (478.00 B)
This is a digitally signed message part

2004-03-07 18:49:39

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [2.6 patch] MAINTAINERS: remove LAN media entry

On Sun, Mar 07, 2004 at 05:32:46PM +0100, Adrian Bunk wrote:
> In 2.6.4-rc1-mm2, there's exactly one entry marked "Unmaintained"
> (PCMCIA SUBSYSTEM) and there are very few marked "Orphan".
>
> I don't have a strong opinion on this, but my impresion was that usually
> unmaintained device drivers are not listed in MAINTAINERS.

OK - we should follow general practice.

Sam