2004-03-29 20:18:01

by Tom Rini

Subject: [PATCH][KGDB] Drop 'E' packet support

Hi. After working on the docs a bit based on the textfile from Anurekh
Saxena, I'd like to commit the following patch (and similar hunks to the
i386-lite and x86_64 patch) to drop support for the 'E' packet.

This isn't something supported by stock GDB, nor AFAIK is it something
that's been submitted for inclusion in GDB. So I'd really like to drop
this entirely until it's something gdb CVS supports (and I assume would
be documented in
http://sources.redhat.com/gdb/current/onlinedocs/gdb_33.html#SEC656 ).
I could stand putting off the question for now and putting it in the
non-lite patches, but I'd really rather not.

If no one objects, I'd like to commit this noon, -0700 on 30 March.
diff -u linux-2.6.4/kernel/kgdb.c linux-2.6.4/kernel/kgdb.c
--- linux-2.6.4/kernel/kgdb.c 2004-03-19 08:22:37.147169789 -0700
+++ linux-2.6.4/kernel/kgdb.c 2004-03-29 13:13:11.440594007 -0700
@@ -130,11 +130,6 @@
}

void __attribute__ ((weak))
- kgdb_printexceptioninfo(int exceptionNo, int errorcode, char *buffer)
-{
-}
-
-void __attribute__ ((weak))
kgdb_disable_hw_debug(struct pt_regs *regs)
{
}
@@ -875,12 +870,6 @@
int_to_threadref(&thref, threadid);
pack_threadid(remcom_out_buffer + 2, &thref);
break;
-
- case 'E':
- /* Print exception info */
- kgdb_printexceptioninfo(exVector, err_code,
- remcom_out_buffer);
- break;
case 'T':
if (memcmp(remcom_in_buffer + 1,
"ThreadExtraInfo,", 16)) {

--
Tom Rini
http://gate.crashing.org/~trini/

2004-03-30 09:24:41

by Amit S. Kale

Subject: Re: [PATCH][KGDB] Drop 'E' packet support

Fine with me.

-Amit

On Tuesday 30 Mar 2004 1:47 am, Tom Rini wrote:
> Hi. After working on the docs a bit based on the textfile from Anurekh
> Saxena, I'd like to commit the following patch (and similar hunks to the
> i386-lite and x86_64 patch) to drop support for the 'E' packet.
>
> This isn't something supported by stock GDB, nor AFAIK is it something
> that's been submitted for inclusion in GDB. So I'd really like to drop
> this entirely until it's something gdb CVS supports (and I assume would
> be documented in
> http://sources.redhat.com/gdb/current/onlinedocs/gdb_33.html#SEC656 ).
> I could stand putting off the question for now and putting it in the
> non-lite patches, but I'd really rather not.
>
> If no one objects, I'd like to commit this noon, -0700 on 30 March.
> diff -u linux-2.6.4/kernel/kgdb.c linux-2.6.4/kernel/kgdb.c
> --- linux-2.6.4/kernel/kgdb.c 2004-03-19 08:22:37.147169789 -0700
> +++ linux-2.6.4/kernel/kgdb.c 2004-03-29 13:13:11.440594007 -0700
> @@ -130,11 +130,6 @@
> }
>
> void __attribute__ ((weak))
> - kgdb_printexceptioninfo(int exceptionNo, int errorcode, char *buffer)
> -{
> -}
> -
> -void __attribute__ ((weak))
> kgdb_disable_hw_debug(struct pt_regs *regs)
> {
> }
> @@ -875,12 +870,6 @@
> int_to_threadref(&thref, threadid);
> pack_threadid(remcom_out_buffer + 2, &thref);
> break;
> -
> - case 'E':
> - /* Print exception info */
> - kgdb_printexceptioninfo(exVector, err_code,
> - remcom_out_buffer);
> - break;
> case 'T':
> if (memcmp(remcom_in_buffer + 1,
> "ThreadExtraInfo,", 16)) {