2004-04-18 05:54:24

by Giridhar Pemmasani

[permalink] [raw]
Subject: patch to make suspend/resume work



--
Giri


Attachments:
alsa-s3-fix (634.00 B)

2004-04-22 19:50:27

by Pavel Machek

[permalink] [raw]
Subject: Re: patch to make suspend/resume work

Hi!

> It seems that pci config space is messed up after resume for Intel
> ICH4 audio controller (on Dell Latitude D600, but I notice that others
> also complain about this problem). Consequently resume from S3 causes
> oops with snd_intel8x0 module. If the module is removed before suspend
> and loaded afterwards, I still get oops. The following simple patch
> fixes the problem. With this, I can leave alsa untouched during
> suspend/resume.
>


Looks good to me. Probably more drivers need this...
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

2004-04-22 20:04:42

by Giridhar Pemmasani

[permalink] [raw]
Subject: Re: patch to make suspend/resume work

On Tue, 20 Apr 2004 15:50:11 +0200, Pavel Machek <[email protected]> said:

Pavel> Looks good to me. Probably more drivers need this...

Yes.

Sometime back (a few weeks?) Stefan Dosinger mailed (on acpi4linux
list?) about his PCI devices all giving oops on resume and to avoid,
he was using setpci to write back the config space the way it was
before suspend. If the drivers for those devices save/restored, then
they will probably work.

--
Giri